Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 875483002: Use StatsReport::Value::ToString instead of the value member variable direct. (Closed)

Created:
5 years, 11 months ago by tommi (sloooow) - chröme
Modified:
5 years, 9 months ago
Reviewers:
magjed_chromium
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StatsReport::Value::ToString instead of the value member variable direct. This can be landed once the interface change has been made in WebRTC and rolled into Chromium (see here: https://webrtc-codereview.appspot.com/40139004/). BUG=webrtc:2822 Committed: https://crrev.com/f1eb009c56212783050f9695a42f53bd22e4f3ca Cr-Commit-Position: refs/heads/master@{#318694}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/media/peer_connection_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tommi (sloooow) - chröme
Rebase
5 years, 9 months ago (2015-03-01 00:45:41 UTC) #1
tommi (sloooow) - chröme
5 years, 9 months ago (2015-03-01 15:33:43 UTC) #3
magjed_chromium
lgtm
5 years, 9 months ago (2015-03-02 10:15:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875483002/20001
5 years, 9 months ago (2015-03-02 13:09:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 15:23:11 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 15:24:30 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1eb009c56212783050f9695a42f53bd22e4f3ca
Cr-Commit-Position: refs/heads/master@{#318694}

Powered by Google App Engine
This is Rietveld 408576698