Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 875473004: Fix city-list example after changes to scrolling (Closed)

Created:
5 years, 10 months ago by rafaelw
Modified:
5 years, 10 months ago
CC:
mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix city-list example after changes to scrolling. Note that this patch only includes support for the wheel event. I'll follow-up with a patch for scrolling/fling when I have a setup on which I can verify that working. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/44d2c0a13d2350e866945ae2c624c3e06539f5a3

Patch Set 1 #

Total comments: 1

Patch Set 2 : cr comments #

Patch Set 3 : rebase tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -217 lines) Patch
M sky/examples/city-list/city-list.sky View 1 8 chunks +19 lines, -110 lines 0 comments Download
M sky/tests/framework/citylist-expected.txt View 1 2 1 chunk +217 lines, -101 lines 0 comments Download
M sky/tests/framework/citylist-scrolled.sky View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M sky/tests/framework/citylist-scrolled-expected.txt View 1 2 1 chunk +236 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
rafaelw
5 years, 10 months ago (2015-01-29 00:30:18 UTC) #2
esprehn
lgtm, but you can remove the transformY(0) too. https://codereview.chromium.org/875473004/diff/1/sky/examples/city-list/city-list.sky File sky/examples/city-list/city-list.sky (right): https://codereview.chromium.org/875473004/diff/1/sky/examples/city-list/city-list.sky#newcode124 sky/examples/city-list/city-list.sky:124: transform: ...
5 years, 10 months ago (2015-01-29 00:33:54 UTC) #4
esprehn
On 2015/01/29 at 00:33:54, esprehn wrote: > lgtm, but you can remove the transformY(0) too. ...
5 years, 10 months ago (2015-01-29 00:34:07 UTC) #5
abarth-chromium
On 2015/01/29 at 00:34:07, esprehn wrote: > Or maybe you wanted will-change: transform to become ...
5 years, 10 months ago (2015-01-29 00:35:28 UTC) #6
abarth-chromium
I wish there was some way to share code between sky-scrollable and city-list. Maybe there's ...
5 years, 10 months ago (2015-01-29 00:36:08 UTC) #7
rafaelw
updated to use will-change: transform
5 years, 10 months ago (2015-01-29 00:40:26 UTC) #8
rafaelw
5 years, 10 months ago (2015-01-29 00:56:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
44d2c0a13d2350e866945ae2c624c3e06539f5a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698