Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 875473003: Standardize "gpu_times" metric names and add GPU rasterization versions. (Closed)

Created:
5 years, 10 months ago by David Yen
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Standardize "gpu_times" metric names and add GPU rasterization versions. The GPU Times metric event names have been standardized to match the names for other metrics. GPU Rasterization versions have also been added for both GPU times tests. Here is the list of test names: gpu_times.gpu_rasterization.key_mobile_sites_smooth gpu_times.gpu_rasterization.top_25_smooth gpu_times.key_mobile_sites_smooth gpu_times.top_25_smooth R=vmiura@chromium.org BUG=none test=trybots Committed: https://crrev.com/9fbe73b4158beb6beb278af819e075cc3d744210 Cr-Commit-Position: refs/heads/master@{#313825}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improved doc text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M tools/perf/benchmarks/gpu_times.py View 1 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
David Yen
5 years, 10 months ago (2015-01-28 22:49:49 UTC) #1
David Yen
On 2015/01/28 22:49:49, David Yen wrote: The metrics seem to be running nicely, here is ...
5 years, 10 months ago (2015-01-28 22:51:13 UTC) #3
vmiura
LGTM https://codereview.chromium.org/875473003/diff/1/tools/perf/benchmarks/gpu_times.py File tools/perf/benchmarks/gpu_times.py (right): https://codereview.chromium.org/875473003/diff/1/tools/perf/benchmarks/gpu_times.py#newcode41 tools/perf/benchmarks/gpu_times.py:41: """Measures GPU timeline metric on key mobile sites.""" ...
5 years, 10 months ago (2015-01-29 01:26:55 UTC) #4
David Yen
https://codereview.chromium.org/875473003/diff/1/tools/perf/benchmarks/gpu_times.py File tools/perf/benchmarks/gpu_times.py (right): https://codereview.chromium.org/875473003/diff/1/tools/perf/benchmarks/gpu_times.py#newcode41 tools/perf/benchmarks/gpu_times.py:41: """Measures GPU timeline metric on key mobile sites.""" On ...
5 years, 10 months ago (2015-01-29 17:17:46 UTC) #5
epennerAtGoogle
LGTM
5 years, 10 months ago (2015-01-29 20:19:45 UTC) #6
David Yen
On 2015/01/29 20:19:45, epennerAtGoogle wrote: > LGTM sorry, could you LGTM from your chromium account?
5 years, 10 months ago (2015-01-29 23:08:46 UTC) #7
epenner
On 2015/01/29 23:08:46, David Yen wrote: > On 2015/01/29 20:19:45, epennerAtGoogle wrote: > > LGTM ...
5 years, 10 months ago (2015-01-29 23:20:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875473003/20001
5 years, 10 months ago (2015-01-29 23:25:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 23:29:47 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9fbe73b4158beb6beb278af819e075cc3d744210 Cr-Commit-Position: refs/heads/master@{#313825}
5 years, 10 months ago (2015-01-29 23:32:06 UTC) #12
oystein (OOO til 10th of July)
5 years, 10 months ago (2015-02-02 21:34:02 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/896593002/ by oysteine@chromium.org.

The reason for reverting is: Speculative revert for crbug.com/453131.

Powered by Google App Engine
This is Rietveld 408576698