[Chromoting] (Re-)Enable AppRemoting sample apps by default in all.gyp.

[Chromoting] (Re-)Enable AppRemoting sample apps by default in all.gyp.

"by default" = whenever we build Chromoting.

This is a re-land of crrev.com/878793003, which failed on
the Official builds.

The build problem has been fixed in crrev.com/886543002.

BUG=

Committed: https://crrev.com/108f744ccea14feb5019f1f8787fa3c265e83d0e
Cr-Commit-Position: refs/heads/master@{#314160}

[garykac, 2015-01-28 19:32:33]

garykac@chromium.org changed reviewers:
+ brettw@chromium.org

[garykac, 2015-01-28 19:32:34]

Re-land of 878793003. Previous break was fixed in 886543002.

I tested this on a local Official build, but didn't see a way to run Official
bots before committing.

[garykac, 2015-01-30 18:34:08]

On 2015/01/28 19:32:34, garykac wrote:
> Re-land of 878793003. Previous break was fixed in 886543002.
> 
> I tested this on a local Official build, but didn't see a way to run Official
> bots before committing.

ping!

[brettw, 2015-01-30 18:51:05]

Sorry I missed this. We're in the middle of trying to remove the wildcards from
the 'all' target. Can you update it so this patch doesn't set us back?

There are two ways, if there is just one target, just list it. Otherwise, you
can make some kind of "remoting_all" target and link that from build's 'all'
target. See Dirk's patch for base: https://codereview.chromium.org/883213003/
This also has the advantage that the remoting team can update this as they
desire without getting different owners reviews.

[garykac, 2015-01-30 21:07:23]

On 2015/01/30 18:51:05, brettw wrote:
> Sorry I missed this. We're in the middle of trying to remove the wildcards
from
> the 'all' target. Can you update it so this patch doesn't set us back?
> 
> There are two ways, if there is just one target, just list it. Otherwise, you
> can make some kind of "remoting_all" target and link that from build's 'all'
> target. See Dirk's patch for base: https://codereview.chromium.org/883213003/
> This also has the advantage that the remoting team can update this as they
> desire without getting different owners reviews.

Done.

Although I feel like I'm cheating. I assume that you're just trying to get rid
of wildcards in all.gyp, not get rid of wildcards in all gyps?

[brettw, 2015-01-30 23:05:01]

Er, we are trying to get rid of all of them. GN doesn't have this (by design)
and thought it would be confusing if the GYP and GN concepts of what the build
are diverged.

[garykac, 2015-01-30 23:47:38]

On 2015/01/30 23:05:01, brettw wrote:
> Er, we are trying to get rid of all of them. GN doesn't have this (by design)
> and thought it would be confusing if the GYP and GN concepts of what the build
> are diverged.

Ah. That'll change this one-line cl into a 40-50 line cl.  That sounds better in
a separate cl - which I'm happy to do, it just doesn't feel right in this one.

[brettw, 2015-01-31 00:26:41]

On 2015/01/30 23:47:38, garykac wrote:
> On 2015/01/30 23:05:01, brettw wrote:
> > Er, we are trying to get rid of all of them. GN doesn't have this (by
design)
> > and thought it would be confusing if the GYP and GN concepts of what the
build
> > are diverged.
> 
> Ah. That'll change this one-line cl into a 40-50 line cl.  That sounds better
in
> a separate cl - which I'm happy to do, it just doesn't feel right in this one.

That's OK, please do that soon. LGTM

[garykac, 2015-01-31 00:37:13]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2015-01-31 00:38:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/875463004/40001

[commit-bot: I haz the power, 2015-01-31 02:42:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-31 02:42:28]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[garykac, 2015-02-02 15:52:06]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2015-02-02 15:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/875463004/40001

[commit-bot: I haz the power, 2015-02-02 17:01:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-02 17:02:48]

Patchset 3 (id:??) landed as
https://crrev.com/108f744ccea14feb5019f1f8787fa3c265e83d0e
Cr-Commit-Position: refs/heads/master@{#314160}

[garykac, 2015-02-13 17:17:24]

On 2015/01/31 00:26:41, brettw wrote:
> On 2015/01/30 23:47:38, garykac wrote:
> > On 2015/01/30 23:05:01, brettw wrote:
> > > Er, we are trying to get rid of all of them. GN doesn't have this (by
> design)
> > > and thought it would be confusing if the GYP and GN concepts of what the
> build
> > > are diverged.
> > 
> > Ah. That'll change this one-line cl into a 40-50 line cl.  That sounds
better
> in
> > a separate cl - which I'm happy to do, it just doesn't feel right in this
one.
> 
> That's OK, please do that soon. LGTM

FYI: Done in crrev.com/906463005

[brettw, 2015-02-13 20:31:16]

On 2015/02/13 17:17:24, garykac wrote:
> On 2015/01/31 00:26:41, brettw wrote:
> > On 2015/01/30 23:47:38, garykac wrote:
> > > On 2015/01/30 23:05:01, brettw wrote:
> > > > Er, we are trying to get rid of all of them. GN doesn't have this (by
> > design)
> > > > and thought it would be confusing if the GYP and GN concepts of what the
> > build
> > > > are diverged.
> > > 
> > > Ah. That'll change this one-line cl into a 40-50 line cl.  That sounds
> better
> > in
> > > a separate cl - which I'm happy to do, it just doesn't feel right in this
> one.
> > 
> > That's OK, please do that soon. LGTM
> 
> FYI: Done in crrev.com/906463005

Thanks!