Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/enhanced_bookmarks/test_image_store.cc

Issue 875463003: ★ Record the image dominant color in the image database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/enhanced_bookmarks/test_image_store.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/enhanced_bookmarks/test_image_store.cc
diff --git a/components/enhanced_bookmarks/test_image_store.cc b/components/enhanced_bookmarks/test_image_store.cc
index 19d505ff650a80fd065418a0dc881c38df960949..9b11cdfdb36fb9f6435c2b9aa730a94b9a91bd3b 100644
--- a/components/enhanced_bookmarks/test_image_store.cc
+++ b/components/enhanced_bookmarks/test_image_store.cc
@@ -18,15 +18,11 @@ bool TestImageStore::HasKey(const GURL& page_url) {
}
void TestImageStore::Insert(const GURL& page_url,
- const GURL& image_url,
- const gfx::Image& image) {
+ const enhanced_bookmarks::ImageRecord& image) {
DCHECK(sequence_checker_.CalledOnValidSequencedThread());
Erase(page_url);
- store_.insert(std::make_pair(
- page_url,
- std::make_pair(image,
- image_url)));
+ store_.insert(std::make_pair(page_url, image));
}
void TestImageStore::Erase(const GURL& page_url) {
@@ -35,14 +31,13 @@ void TestImageStore::Erase(const GURL& page_url) {
store_.erase(page_url);
}
-std::pair<gfx::Image, GURL> TestImageStore::Get(const GURL& page_url) {
+enhanced_bookmarks::ImageRecord TestImageStore::Get(const GURL& page_url) {
DCHECK(sequence_checker_.CalledOnValidSequencedThread());
- ImageMap::const_iterator pair_enumerator = store_.find(page_url);
- if (pair_enumerator == store_.end())
- return std::make_pair(gfx::Image(), GURL());
+ if (store_.find(page_url) == store_.end())
+ return enhanced_bookmarks::ImageRecord();
- return std::make_pair(store_[page_url].first, store_[page_url].second);
+ return store_[page_url];
}
gfx::Size TestImageStore::GetSize(const GURL& page_url) {
@@ -52,7 +47,7 @@ gfx::Size TestImageStore::GetSize(const GURL& page_url) {
if (pair_enumerator == store_.end())
return gfx::Size();
- return store_[page_url].first.Size();
+ return store_[page_url].image.Size();
}
void TestImageStore::GetAllPageUrls(std::set<GURL>* urls) {
@@ -77,9 +72,10 @@ int64 TestImageStore::GetStoreSizeInBytes() {
size += sizeof(it->first);
size += it->first.spec().length();
size += sizeof(it->second);
- SkBitmap bitmap = it->second.first.AsBitmap();
+ SkBitmap bitmap = it->second.image.AsBitmap();
size += bitmap.getSize();
- size += it->second.second.spec().length();
+ size += it->second.url.spec().length();
+ size += sizeof(it->second.dominant_color);
}
return size;
}
« no previous file with comments | « components/enhanced_bookmarks/test_image_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698