Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: runtime/vm/object.h

Issue 875443002: Store pc offset instead of absolute pc in the pc descriptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed arm/mips/arm64 build Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 43041)
+++ runtime/vm/object.h (working copy)
@@ -3182,7 +3182,7 @@
class PcDescriptors : public Object {
public:
void AddDescriptor(intptr_t index,
- uword pc,
+ uword pc_offset,
RawPcDescriptors::Kind kind,
int64_t deopt_id,
int64_t token_pos, // Or deopt reason.
@@ -3189,7 +3189,7 @@
intptr_t try_index) const { // Or deopt index.
NoGCScope no_gc;
RawPcDescriptors::PcDescriptorRec* rec = recAt(index);
- rec->set_pc(pc);
+ rec->set_pc_offset(pc_offset);
rec->set_kind(kind);
ASSERT(Utils::IsInt(32, deopt_id));
rec->set_deopt_id(static_cast<int32_t>(deopt_id));
@@ -3219,9 +3219,6 @@
static RawPcDescriptors* New(intptr_t num_descriptors, bool has_try_index);
- // Returns 0 if not found.
- uword GetPcForKind(RawPcDescriptors::Kind kind) const;
-
// Verify (assert) assumptions about pc descriptors in debug mode.
void Verify(const Function& function) const;
@@ -3253,9 +3250,9 @@
}
}
- uword Pc() const {
+ uword PcOffset() const {
NoGCScope no_gc;
- return descriptors_.recAt(current_ix_)->pc();
+ return descriptors_.recAt(current_ix_)->pc_offset();
}
intptr_t DeoptId() const {
NoGCScope no_gc;
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698