event_mon: actually implemented push

infra/libs/event_mon/router.py

Index: infra/libs/event_mon/router.py
diff --git a/infra/libs/event_mon/router.py b/infra/libs/event_mon/router.py
index 02d5f7911b164c5165d0114070d6380c4c4d6c5d..478bdb86a7c05e9b08378a20b480db1c0a9eb621 100644
--- a/infra/libs/event_mon/router.py
+++ b/infra/libs/event_mon/router.py
@@ -4,6 +4,7 @@
 
 import Queue
 import logging
+import requests
 import threading
 import time
 
@@ -26,10 +27,9 @@ class _Router(object):
   ... fill in event ...
   router.push_event(event)
   """
-  def __init__(self, dry_run=True):
-    # dry_run is meant for local testing and unit testing. When True, this
-    # object should have no side effect.
-    self.dry_run = dry_run
+  def __init__(self, endpoint=None):
+    # endpoint == None means 'dry run'. No data is sent.
+    self.endpoint = endpoint
 
     self.event_queue = Queue.Queue()
     self._thread = threading.Thread(target=self._router)
@@ -44,10 +44,11 @@ class _Router(object):
 
       # Set this time at the very last moment
       events.request_time_ms = time_ms()
-
-      if not self.dry_run:  # pragma: no cover
-        # TODO(pgervais): Actually do something
-        pass
+      if self.endpoint:  # pragma: no cover
+        # TODO(pgervais): log when something fails

[Sergey Berezin, 2015/02/07 03:16:47]

nit: dot at the end of the sentence.

[pgervais, 2015/02/10 10:36:37]

Done.

+        requests.post(self.endpoint, data=events.SerializeToString())
+      else:
+        print('fake post request')
 
   def close(self, timeout=None):
     """
@@ -81,7 +82,8 @@ class _Router(object):
       return False
 
     # Dumb implementation, can be made more sophisticated (batching)

[Sergey Berezin, 2015/02/07 03:16:47]

nit: this sounds like a TODO. And is missing a dot at the end.

[pgervais, 2015/02/10 10:36:37]

Done.

-    request = LogRequestLite()
-    request.log_event.extend((event,))  # copies the protobuf
-    self.event_queue.put(request)
+    request_p = LogRequestLite()
+    request_p.log_source_name = 'CHROME_INFRA'
+    request_p.log_event.extend((event,))  # copies the protobuf
+    self.event_queue.put(request_p)
     return True