event_mon: actually implemented push

event_mon: actually implemented push

Plus changed command-line options to allow passing three modes:
dry-run, test, and prod.

BUG=444091
Committed: https://chromium.googlesource.com/infra/infra/+/20f7165c64cb3748d36fb7f887239889c76797f1

[pgervais, 2015-02-07 01:21:38]

pgervais@chromium.org changed reviewers:
+ sergeyberezin@chromium.org, stip@chromium.org

[pgervais, 2015-02-07 01:21:39]

Here's a working client code. It has to be optimized in many places, but it's a
first step.

[Sergey Berezin, 2015-02-07 03:16:47]

LGTM + nits.

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/monitor...
File infra/libs/event_mon/monitoring.py (right):

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/monitor...
infra/libs/event_mon/monitoring.py:44: # TODO: Serialize protobuf here.
nit: stale TODO.

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/router.py
File infra/libs/event_mon/router.py (right):

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/router....
infra/libs/event_mon/router.py:48: # TODO(pgervais): log when something fails
nit: dot at the end of the sentence.

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/router....
infra/libs/event_mon/router.py:84: # Dumb implementation, can be made more
sophisticated (batching)
nit: this sounds like a TODO. And is missing a dot at the end.

[pgervais, 2015-02-10 10:36:37]

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/monitor...
File infra/libs/event_mon/monitoring.py (right):

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/monitor...
infra/libs/event_mon/monitoring.py:44: # TODO: Serialize protobuf here.
On 2015/02/07 03:16:47, Sergey Berezin wrote:
> nit: stale TODO.

Done.

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/router.py
File infra/libs/event_mon/router.py (right):

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/router....
infra/libs/event_mon/router.py:48: # TODO(pgervais): log when something fails
On 2015/02/07 03:16:47, Sergey Berezin wrote:
> nit: dot at the end of the sentence.

Done.

https://codereview.chromium.org/875403010/diff/1/infra/libs/event_mon/router....
infra/libs/event_mon/router.py:84: # Dumb implementation, can be made more
sophisticated (batching)
On 2015/02/07 03:16:47, Sergey Berezin wrote:
> nit: this sounds like a TODO. And is missing a dot at the end.

Done.

[pgervais, 2015-02-10 10:37:15]

New patchsets have been uploaded after l-g-t-m from sergeyberezin@chromium.org

[pgervais, 2015-02-10 10:37:25]

The CQ bit was checked by pgervais@chromium.org

[commit-bot: I haz the power, 2015-02-10 10:37:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/875403010/20001

[commit-bot: I haz the power, 2015-02-10 10:40:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/20f7165c64cb3748d36fb7f887239...