Wait for eventhandler to shut down before exiting

dart/runtime/bin/main.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
@@ skipping 1080 matching lines @@
   }
 
   Dart_ExitScope();
   // Shutdown the isolate.
   Dart_ShutdownIsolate();
   // Terminate process exit-code handler.
   Process::TerminateExitCodeHandler();
 
   Dart_Cleanup();
 
+  // Stop event handler.
+  EventHandler::Stop();

[kustermann, 2015/02/04 20:58:43]

I'm actually not 100% sure whether this should be here or before
Dart_ShutdownIsolate().

What can happen is that the event handler thread is still posting messages to a
`Dart_Port` as long as EventHandler::Stop() isn't done.

[What happens if the eventhandler posts a message to a Dart_Port where the
receive port is in an isolate that is already dead?]

[Søren Gjesse, 2015/02/04 21:57:09]

It should be safe to post to send ports where the the receive port is gone. That
should have no effect.

+
   // Free copied argument strings if converted.
   if (argv_converted) {
     for (int i = 0; i < argc; i++) free(argv[i]);
   }
 
   // Free environment if any.
   if (environment != NULL) {
     for (HashMap::Entry* p = environment->Start();
          p != NULL;
          p = environment->Next(p)) {
       free(p->key);
       free(p->value);
     }
     delete environment;
   }
 
   exit(Process::GlobalExitCode());
 }
 
 }  // namespace bin
 }  // namespace dart
 
 int main(int argc, char** argv) {
   dart::bin::main(argc, argv);
   UNREACHABLE();
 }