Issue 875403005: Make SkWriter32::snapshotAsData() a dumb copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 875403005: Make SkWriter32::snapshotAsData() a dumb copy. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Make SkWriter32::snapshotAsData() a dumb copy. SkWriter32::snapshotAsData() is no longer performance critical. It's only used when we're serializing to disk. BUG=skia:2289 Committed: https://skia.googlesource.com/skia/+/4f358fc269077219c18f30f4752e3678a15c222a

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -67 lines)			Patch
M	include/core/SkWriter32.h	View	4 chunks	+0 lines, -11 lines	0 comments	Download
M	src/core/SkWriter32.cpp	View	1 chunk	+1 line, -25 lines	0 comments	Download
M	tests/Writer32Test.cpp	View	1 chunk	+0 lines, -31 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875403005/1

5 years, 10 months ago (2015-01-29 19:53:33 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 20:03:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4f358fc269077219c18f30f4752e3678a15c222a