LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html - Issue 875363002: Sort header names in Access-Control-Request-Headers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html

Issue 875363002: Sort header names in Access-Control-Request-Headers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tyoshino's comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js ('k') | LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html

diff --git a/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html b/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html

similarity index 64%

copy from LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html

copy to LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html

index 625f731fedf5cdd8184054e36faf57c54c5b8525..7814982ebed4ba095d0b76f5ca85ce4de4429484 100644

--- a/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html

+++ b/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html

@@ -1,6 +1,6 @@

<html>

<body>

-<p>Test for bug 75089: Access-Control-Request-Headers values should be lowercase.</p>

+<p>Test for bug 452391: Header names in Access-Control-Request-Headers must be sorted.</p>

if (window.testRunner) {

testRunner.dumpAsText();

@@ -10,8 +10,12 @@ if (window.testRunner) {

function sendRequest()

{

var xhr = new XMLHttpRequest;

- xhr.open("GET", "http://localhost:8000/xmlhttprequest/resources/access-control-preflight-request-header-lowercase.php");

- xhr.setRequestHeader("X-Custom-Header", "foobar");

+ xhr.open("GET", "http://localhost:8000/xmlhttprequest/resources/access-control-preflight-request-header-sorted.php");

+ xhr.setRequestHeader("X-Custom-Test", "foobar");

+ xhr.setRequestHeader("X-Custom-ua", "foobar");

+ xhr.setRequestHeader("X-Custom-V", "foobar");

+ xhr.setRequestHeader("X-Custom-s", "foobar");

+ xhr.setRequestHeader("X-Custom-U", "foobar");

xhr.onerror = function() {

document.body.appendChild(document.createTextNode("FAIL: onerror called"));

if (window.testRunner)