Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js

Issue 875363002: Sort header names in Access-Control-Request-Headers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add missing expect.txt Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html » ('j') | LayoutTests/http/tests/xmlhttprequest/resources/access-control-preflight-request-header-sorted.php » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js
diff --git a/LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js b/LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js
index 34a2934b83a284f8cb16486f6c5a3c2745ec3352..b7047274284bea7ee4b9c2890d703fda4d5721c9 100644
--- a/LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js
+++ b/LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js
@@ -131,10 +131,10 @@ var TEST_TARGETS = [
[OTHER_BASE_URL + 'mode=cors&method=GET&headers=CUSTOM&ACAOrigin=*&PACAOrigin=*&PACAHeaders=x-serviceworker-test&PreflightTest=200&PACRMethod=GET&PACRHeaders=x-serviceworker-test',
[fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
[methodIsGET, hasCustomHeader]],
- // FIXME: https://crbug.com/452391
- // [OTHER_BASE_URL + 'mode=cors&method=GET&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=GET&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
- // [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
- // [methodIsGET, hasCustomHeader2]],
+ // Test Access-Control-ARequest-Headers is sorted https://crbug.com/452391
tyoshino (SeeGerritForStatus) 2015/01/29 10:44:53 ARequest -> Request
hiroshige 2015/01/29 11:08:11 Done.
+ [OTHER_BASE_URL + 'mode=cors&method=GET&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=GET&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
+ [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
+ [methodIsGET, hasCustomHeader2]],
// method=POST
@@ -235,10 +235,10 @@ var TEST_TARGETS = [
[OTHER_BASE_URL + 'mode=cors&method=POST&headers=CUSTOM&ACAOrigin=*&PACAOrigin=*&PACAHeaders=x-serviceworker-test&PreflightTest=200&PACRMethod=POST&PACRHeaders=x-serviceworker-test',
[fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
[methodIsPOST, hasCustomHeader]],
- // FIXME: https://crbug.com/452391
- // [OTHER_BASE_URL + 'mode=cors&method=POST&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=POST&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
- // [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
- // [methodIsPOST, hasCustomHeader2]],
+ // Test Access-Control-ARequest-Headers is sorted https://crbug.com/452391
tyoshino (SeeGerritForStatus) 2015/01/29 10:44:53 ARequest -> Request
hiroshige 2015/01/29 11:08:11 Done.
+ [OTHER_BASE_URL + 'mode=cors&method=POST&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=POST&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
+ [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
+ [methodIsPOST, hasCustomHeader2]],
// method=PUT
@@ -346,10 +346,10 @@ var TEST_TARGETS = [
[OTHER_BASE_URL + 'mode=cors&method=PUT&headers=CUSTOM&ACAOrigin=*&PACAOrigin=*&PACAMethods=PUT&PACAHeaders=x-serviceworker-test&PreflightTest=200&PACRMethod=PUT&PACRHeaders=x-serviceworker-test',
[fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
[methodIsPUT, hasCustomHeader]],
- // FIXME: https://crbug.com/452391
- // [OTHER_BASE_URL + 'mode=cors&method=PUT&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAMethods=PUT&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=PUT&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
- // [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
- // [methodIsPUT, hasCustomHeader2]],
+ // Test Access-Control-ARequest-Headers is sorted https://crbug.com/452391
tyoshino (SeeGerritForStatus) 2015/01/29 10:44:53 ARequest -> Request
hiroshige 2015/01/29 11:08:11 Done.
+ [OTHER_BASE_URL + 'mode=cors&method=PUT&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAMethods=PUT&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=PUT&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
+ [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
+ [methodIsPUT, hasCustomHeader2]],
// method=XXX
@@ -458,10 +458,10 @@ var TEST_TARGETS = [
[OTHER_BASE_URL + 'mode=cors&method=XXX&headers=CUSTOM&ACAOrigin=*&PACAOrigin=*&PACAMethods=XXX&PACAHeaders=x-serviceworker-test&PreflightTest=200&PACRMethod=XXX&PACRHeaders=x-serviceworker-test',
[fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
[methodIsXXX, hasCustomHeader]],
- // FIXME: https://crbug.com/452391
- // [OTHER_BASE_URL + 'mode=cors&method=XXX&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAMethods=XXX&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=XXX&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
- // [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
- // [methodIsXXX, hasCustomHeader2]],
+ // Test Access-Control-ARequest-Headers is sorted https://crbug.com/452391
tyoshino (SeeGerritForStatus) 2015/01/29 10:44:53 ditto
hiroshige 2015/01/29 11:08:11 Done.
+ [OTHER_BASE_URL + 'mode=cors&method=XXX&headers=CUSTOM2&ACAOrigin=*&PACAOrigin=*&PACAMethods=XXX&PACAHeaders=x-servicEworker-u, x-servicEworker-ua, x-servicewOrker-test, x-sErviceworker-s, x-sErviceworker-v&PreflightTest=200&PACRMethod=XXX&PACRHeaders=x-serviceworker-s, x-serviceworker-test, x-serviceworker-u, x-serviceworker-ua, x-serviceworker-v',
+ [fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
+ [methodIsXXX, hasCustomHeader2]],
];
if (self.importScripts) {
« no previous file with comments | « no previous file | LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-header-sorted.html » ('j') | LayoutTests/http/tests/xmlhttprequest/resources/access-control-preflight-request-header-sorted.php » ('J')

Powered by Google App Engine
This is Rietveld 408576698