Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 875353003: Re-land: Tweak output of (memcheck|drmemory)_analyze.py. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Tweak output of (memcheck|drmemory)_analyze.py. Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us to extract them with GTestLogParser and use them as snippets. Re-land with syntax errors fixed. BUG=453020 TBR=thestig@chromium.org Committed: https://crrev.com/6649f47de20c2ea42f712eb7029b4fc35a475910 Cr-Commit-Position: refs/heads/master@{#313707}

Patch Set 1 #

Patch Set 2 : fix another error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/valgrind/drmemory_analyze.py View 1 chunk +6 lines, -1 line 0 comments Download
M tools/valgrind/memcheck_analyze.py View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
earthdok
5 years, 10 months ago (2015-01-29 13:23:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875353003/1
5 years, 10 months ago (2015-01-29 13:24:12 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/29992)
5 years, 10 months ago (2015-01-29 14:43:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875353003/20001
5 years, 10 months ago (2015-01-29 14:45:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 15:24:00 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6649f47de20c2ea42f712eb7029b4fc35a475910 Cr-Commit-Position: refs/heads/master@{#313707}
5 years, 10 months ago (2015-01-29 15:24:58 UTC) #9
Lei Zhang
5 years, 10 months ago (2015-01-29 22:31:39 UTC) #10
Message was sent while issue was closed.
lgtm, for reals this time.

Powered by Google App Engine
This is Rietveld 408576698