sky/engine/core/dom/ScriptedAnimationController.cpp - Issue 875283003: Make all callers of scheduleAnimation() use scheduleVisualUpdate().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/ScriptedAnimationController.cpp

Issue 875283003: Make all callers of scheduleAnimation() use scheduleVisualUpdate(). (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/ScriptedAnimationController.cpp

diff --git a/sky/engine/core/dom/ScriptedAnimationController.cpp b/sky/engine/core/dom/ScriptedAnimationController.cpp

index 25e975fda6d31e6e72eca5764b72eb696cfa79f5..0dc84ab3b7e6a7552258b90287e8d70788b7413b 100644

--- a/sky/engine/core/dom/ScriptedAnimationController.cpp

+++ b/sky/engine/core/dom/ScriptedAnimationController.cpp

@@ -226,8 +226,8 @@ void ScriptedAnimationController::scheduleAnimationIfNeeded()

if (!m_callbacks.size() && !m_eventQueue.size() && !m_mediaQueryListListeners.size())

return;

- if (FrameView* frameView = m_document->view())

- frameView->scheduleAnimation();

+ // TODO(esprehn): This causes a full raster on every raf even if nothing changed.

+ m_document->scheduleVisualUpdate();

}

« no previous file with comments | « sky/engine/core/animation/PendingAnimations.cpp ('k') | sky/engine/core/frame/FrameView.h » ('j') | no next file with comments »