sky/engine/core/animation/PendingAnimations.cpp - Issue 875283003: Make all callers of scheduleAnimation() use scheduleVisualUpdate().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/animation/PendingAnimations.cpp

Issue 875283003: Make all callers of scheduleAnimation() use scheduleVisualUpdate(). (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/animation/PendingAnimations.cpp

diff --git a/sky/engine/core/animation/PendingAnimations.cpp b/sky/engine/core/animation/PendingAnimations.cpp

index 75879065a74a12664550cefdd611c342f2e66f97..7025e63114f70595df1d055954b57e32b2de57cb 100644

--- a/sky/engine/core/animation/PendingAnimations.cpp

+++ b/sky/engine/core/animation/PendingAnimations.cpp

@@ -46,8 +46,7 @@ void PendingAnimations::add(AnimationPlayer* player)

m_pending.append(player);

Document* document = player->timeline()->document();

- if (document->view())

- document->view()->scheduleAnimation();

+ document->scheduleVisualUpdate();

bool visible = document->page() && document->page()->visibilityState() == PageVisibilityStateVisible;

if (!visible && !m_timer.isActive()) {