extensions/shell/browser/shell_app_delegate.h - Issue 875273003: Hidden windows should not keep Chrome alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_app_delegate.h

Issue 875273003: Hidden windows should not keep Chrome alive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually fix the ASAN issue. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/shell_app_delegate.h

diff --git a/extensions/shell/browser/shell_app_delegate.h b/extensions/shell/browser/shell_app_delegate.h

index 6690d7a0981c90cca852de0aa865ab7761217a6b..410329e27626b924e0d298f40d1bc5140f6edc9c 100644

--- a/extensions/shell/browser/shell_app_delegate.h

+++ b/extensions/shell/browser/shell_app_delegate.h

@@ -50,6 +50,8 @@ class ShellAppDelegate : public AppDelegate {

bool blocked) override;

bool IsWebContentsVisible(content::WebContents* web_contents) override;

void SetTerminatingCallback(const base::Closure& callback) override;

+ void OnHide() override {}

+ void OnShow() override {}

private:

DISALLOW_COPY_AND_ASSIGN(ShellAppDelegate);

« no previous file with comments | « extensions/browser/app_window/app_window.cc ('k') | no next file » | no next file with comments »