extensions/browser/app_window/app_window.cc - Issue 875273003: Hidden windows should not keep Chrome alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 875273003: Hidden windows should not keep Chrome alive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually fix the ASAN issue. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index 9256228d5e861513999488361282932837ddef80..83f29714f43fc036ca6371e82a0fa4f2ebf2827e 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -660,6 +660,7 @@ void AppWindow::SetContentSizeConstraints(const gfx::Size& min_size,

}

void AppWindow::Show(ShowType show_type) {

+ app_delegate_->OnShow();

bool was_hidden = is_hidden_ || !has_been_shown_;

is_hidden_ = false;

@@ -696,6 +697,7 @@ void AppWindow::Hide() {

show_on_first_paint_ = false;

GetBaseWindow()->Hide();

AppWindowRegistry::Get(browser_context_)->AppWindowHidden(this);

+ app_delegate_->OnHide();

}

void AppWindow::SetAlwaysOnTop(bool always_on_top) {