chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js - Issue 875273003: Hidden windows should not keep Chrome alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js

Issue 875273003: Hidden windows should not keep Chrome alive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually fix the ASAN issue. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js

diff --git a/chrome/test/data/extensions/platform_apps/hidden/test.js b/chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js

similarity index 50%

copy from chrome/test/data/extensions/platform_apps/hidden/test.js

copy to chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js

index c11022784fb68549df4d1fd6b655d82c0107a5f4..d1a7ff13ce95325831634072e2fb1dd6722cb04c 100644

--- a/chrome/test/data/extensions/platform_apps/hidden/test.js

+++ b/chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js

@@ -3,9 +3,14 @@

// found in the LICENSE file.

chrome.app.runtime.onLaunched.addListener(function() {

- chrome.app.window.create('main.html', {

+ chrome.app.window.create('empty.html', {

hidden: true,

- }, function () {

- chrome.test.sendMessage('Launched');

+ }, function (win) {

+ chrome.test.sendMessage('Launched', function () {

+ setTimeout(function () {

+ win.show();

+ chrome.test.sendMessage('Shown');

+ }, 3000);

+ });

});

-});

+});