Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(858)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/platform_apps/hidden_then_shown/manifest.json
Issue
875273003
:
Hidden windows should not keep Chrome alive. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually fix the ASAN issue.
Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/apps/app_window_interactive_uitest.cc
chrome/browser/ui/apps/chrome_app_delegate.h
chrome/browser/ui/apps/chrome_app_delegate.cc
chrome/test/data/extensions/platform_apps/hidden/test.js
chrome/test/data/extensions/platform_apps/hidden_then_shown/empty.html
chrome/test/data/extensions/platform_apps/hidden_then_shown/manifest.json
chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js
extensions/browser/app_window/app_delegate.h
extensions/browser/app_window/app_window.cc
extensions/shell/browser/shell_app_delegate.h
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/data/extensions/platform_apps/hidden_then_shown/empty.html
('k') |
chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {
1 {
2
"name": "Platform App
Restart Test
",
2
"name": "Platform App
Hidden Then Shown
",
3 "version": "1",
3 "version": "1",
4 "manifest_version": 2,
4 "manifest_version": 2,
5 "app": {
5 "app": {
6 "background": {
6 "background": {
7 "scripts": ["test.js"]
7 "scripts": ["test.js"]
8 }
8 }
9 }
9 }
10 }
10 }
OLD
NEW
« no previous file with comments
|
« chrome/test/data/extensions/platform_apps/hidden_then_shown/empty.html
('k') |
chrome/test/data/extensions/platform_apps/hidden_then_shown/test.js »
('j') |
no next file with comments »
Issue 875273003: Hidden windows should not keep Chrome alive. (Closed)
Created 5 years, 10 months ago by jackhou1
Modified 5 years, 10 months ago
Reviewers: benwells
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 10
This is Rietveld
408576698
Chromium Code Reviews
Issue 875273003:
Hidden windows should not keep Chrome alive. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master