Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 875243003: Add sync experiment flag for wallet datatype. (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add sync experiment flag for wallet datatype. If either the sync experiment OR the command line flag is present, the feature is enabled. (Enabling the feature also gives the user the ability to control it via a separate pref.) BUG= Committed: https://crrev.com/4e911e45e27caf4a92dc71a60c32b20e77a17430 Cr-Commit-Position: refs/heads/master@{#314407}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -11 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M components/autofill/core/common/autofill_pref_names.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/autofill_pref_names.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M sync/internal_api/public/util/experiments.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M sync/protocol/experiments_specifics.proto View 1 2 chunks +6 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
We currently have a command line flag that controls whether the feature is enabled. That ...
5 years, 11 months ago (2015-01-27 02:25:08 UTC) #2
Evan Stade
updated, PTAL
5 years, 10 months ago (2015-02-03 01:59:48 UTC) #3
Nicolas Zea
sync LGTM
5 years, 10 months ago (2015-02-03 18:34:39 UTC) #4
brettw
lgtm
5 years, 10 months ago (2015-02-03 20:29:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875243003/20001
5 years, 10 months ago (2015-02-03 20:32:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 21:08:47 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 21:09:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e911e45e27caf4a92dc71a60c32b20e77a17430
Cr-Commit-Position: refs/heads/master@{#314407}

Powered by Google App Engine
This is Rietveld 408576698