Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 875183003: Minor changes to RealPanClient to get a bit farther (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor changes to RealPanClient to get a bit farther in the getrealpan flow. Also, switch to using RealPanClient instead of fake card numbers (meaning we can not demo the UI until getrealpan works). BUG=451286 Committed: https://crrev.com/dde479d50f5bd5cf5d10447aab05814ee7b48028 Cr-Commit-Position: refs/heads/master@{#314369}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : checkpoint #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -49 lines) Patch
M components/autofill/core/browser/autofill_manager.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 3 3 chunks +7 lines, -32 lines 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 1 2 3 7 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 10 months ago (2015-02-02 19:45:06 UTC) #2
Evan Stade
ping
5 years, 10 months ago (2015-02-03 18:17:14 UTC) #3
brettw
sorry, lgtm
5 years, 10 months ago (2015-02-03 18:18:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875183003/60001
5 years, 10 months ago (2015-02-03 18:21:15 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-03 18:24:27 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 18:25:50 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/dde479d50f5bd5cf5d10447aab05814ee7b48028
Cr-Commit-Position: refs/heads/master@{#314369}

Powered by Google App Engine
This is Rietveld 408576698