Issue 875183002: Make it possible to pass a default url to sky_debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 875183002: Make it possible to pass a default url to sky_debugger (Closed)

Created:
5 years, 11 months ago by eseidel

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make it possible to pass a default url to sky_debugger sky_debugger will load the default url in every view that it's asked to embed. Think of the default_url as being like the home-page in a conventional browser. I also fixed prompt.cc to not terminate the entire mojo environment when it can't start itself, but rather just quit its own application. With this patch I'm able to hack up mojo_shell to be able to have a sensible default behavior when clicked from the Android homescreen, but I'll land those hacks in a separate change. TBR=abarth@chromium.org BUG=451620 Committed: https://chromium.googlesource.com/external/mojo/+/008ba6e0375d7513e05a1a2382bcafb8599d593c

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -5 lines)			Patch
M	sky/tools/debugger/debugger.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/tools/debugger/debugger.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sky/tools/debugger/prompt/prompt.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

Committed patchset #1 (id:1) manually as 008ba6e0375d7513e05a1a2382bcafb8599d593c (presubmit successful).

5 years, 11 months ago (2015-01-26 21:19:10 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages