Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring.

pkg/analysis_server/test/mocks.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mocks;
 
 @MirrorsUsed(targets: 'mocks', override: '*')
 import 'dart:mirrors';
 import 'dart:async';
 import 'dart:io';
@@ skipping 49 matching lines @@
  */
 Future pumpEventQueue([int times = 50]) {
   if (times == 0) return new Future.value();
   // We use a delayed future to allow microtask events to finish. The
   // Future.value or Future() constructors use scheduleMicrotask themselves and
   // would therefore not wait for microtask callbacks that are scheduled after
   // invoking this method.
   return new Future.delayed(Duration.ZERO, () => pumpEventQueue(times - 1));
 }
 
-/**
- * Returns a [Future] that completes when the given [AnalysisServer] finished
- * all its scheduled tasks.
- */
-Future waitForServerOperationsPerformed(AnalysisServer server) {
-  if (server.isAnalysisComplete()) {
-    return new Future.value();
-  }
-  // We use a delayed future to allow microtask events to finish. The
-  // Future.value or Future() constructors use scheduleMicrotask themselves and
-  // would therefore not wait for microtask callbacks that are scheduled after
-  // invoking this method.
-  return new Future.delayed(
-      Duration.ZERO,
-      () => waitForServerOperationsPerformed(server));
-}
-
 typedef void MockServerOperationPerformFunction(AnalysisServer server);
 
 class MockAnalysisContext extends StringTypedMock implements AnalysisContext {
   MockAnalysisContext(String name) : super(name);
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 }
 
 class MockClassElement extends TypedMock implements ClassElement {
   final ElementKind kind = ElementKind.CLASS;
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
@@ skipping 401 matching lines @@
     }
     return mismatchDescription;
   }
 
   @override
   bool matches(item, Map matchState) {
     Response response = item;
     return response != null && response.id == _id && response.error == null;
   }
 }