Issue 875133002: x11: Fix build for virtual/override style changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 875133002: x11: Fix build for virtual/override style changes. (Closed)

Created:
5 years, 11 months ago by sadrul

Modified:
5 years, 11 months ago

Reviewers:
dcheng

CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	ui/events/platform/x11/x11_event_source_libevent.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (1 generated)

dcheng

On 2015/01/26 at 19:09:22, sadrul wrote: > Lgtm. Is this not covered by trybots somewhere? ...

5 years, 11 months ago (2015-01-26 19:46:15 UTC) #3

sadrul

On 2015/01/26 19:46:15, dcheng wrote: > On 2015/01/26 at 19:09:22, sadrul wrote: > > > ...

5 years, 11 months ago (2015-01-26 19:51:22 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/9376f5ad01af632153f75e3dbf9fc5bc8d508039 Cr-Commit-Position: refs/heads/master@{#313104}

5 years, 11 months ago (2015-01-26 19:54:20 UTC) #5

sadrul

5 years, 11 months ago (2015-01-26 19:54:30 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9376f5ad01af632153f75e3dbf9fc5bc8d508039 (presubmit successful).