Chromium Code Reviews

Issue 875113004: Revert of Add WeakMap to v8.h (Closed)

Created:
5 years, 10 months ago by vogelheim
Modified:
5 years, 10 months ago
Reviewers:
jochen (gone - plz use gerrit), Michael Starzinger, yurys
CC:
Paweł Hajdan Jr., v8-dev, aandrey, kozy, alph, loislo
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add WeakMap to v8.h (patchset #3 id:40001 of https://codereview.chromium.org/886473005/) Reason for revert: Breaks Win32 build bot. Original issue's description: > Add WeakMap to v8.h > > A new map wich references its keys weakly is added to v8.h. Internally it uses the same storage as JSWeakMap but doesn't depend on the JavaScript part of WeakMap implementation in weak-collection.js, hence it can be instantiated without entering any context. > > BUG=chromium:437416 > LOG=Y > > Committed: https://crrev.com/37d4c57630636f21e3add8d3d1c7c978ff5fc8e0 > Cr-Commit-Position: refs/heads/master@{#26401} TBR=jochen@chromium.org,mstarzinger@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:437416

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+40 lines, -267 lines)
M include/v8.h View 1 chunk +0 lines, -25 lines 0 comments
M src/api.cc View 1 chunk +0 lines, -106 lines 0 comments
M src/factory.h View 1 chunk +0 lines, -2 lines 0 comments
M src/factory.cc View 1 chunk +0 lines, -9 lines 0 comments
M src/runtime/runtime.h View 1 chunk +0 lines, -7 lines 0 comments
M src/runtime/runtime-collections.cc View 5 chunks +26 lines, -42 lines 0 comments
M test/cctest/test-api.cc View 2 chunks +0 lines, -73 lines 0 comments
M test/cctest/test-weakmaps.cc View 2 chunks +9 lines, -2 lines 0 comments
M test/cctest/test-weaksets.cc View 1 chunk +5 lines, -1 line 0 comments

Messages

Total messages: 5 (2 generated)
vogelheim
Created Revert of Add WeakMap to v8.h
5 years, 10 months ago (2015-02-03 14:41:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875113004/1
5 years, 10 months ago (2015-02-03 14:42:26 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 14:43:46 UTC) #4
Failed to apply the patch.

Powered by Google App Engine