Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 875103002: Add a build-time flag for enabling Dart in Sky (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
rafaelw
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a build-time flag for enabling Dart in Sky We're interested in experimenting with using the DartVM in Sky. This build-time flag will let us add Dart bindings without disrupting other working going on in Sky. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8c05f989d2cfa2171504305d4a30582db121df90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M sky/engine/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/config.gni View 3 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-26 16:50:42 UTC) #1
rafaelw
lgtm
5 years, 11 months ago (2015-01-26 16:52:52 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-26 16:57:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c05f989d2cfa2171504305d4a30582db121df90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698