Don't update Media.EME.KeySystemSupport UMA for unprefixed EME

Don't update Media.EME.KeySystemSupport UMA for unprefixed EME

BUG=351501
TEST=existing EME tests pass

Committed: https://crrev.com/607b369291eb47c87582a0f9af2b5f0b4d031dfa
Cr-Commit-Position: refs/heads/master@{#314727}

[jrummell, 2015-01-27 00:45:10]

jrummell@chromium.org changed reviewers:
+ sandersd@chromium.org

[jrummell, 2015-01-27 00:45:11]

PTAL.

[ddorwin, 2015-01-27 00:51:51]

ddorwin@chromium.org changed reviewers:
+ ddorwin@chromium.org

[ddorwin, 2015-01-27 00:51:51]

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
content/renderer/renderer_blink_platform_impl.cc:422: if
(!media::IsSupportedKeySystemWithMediaMimeType(
Instead of adding a bool, the purpose of which is not obvious at the call site,
change the function name to contain "Prefixed". You can hide the bool internally
if necessary.

(I'm not sure where to put "Prefixed". Prefixing the function name would be the
most obvious, but is probably not style compliant. Still, as far as readability
is concerned, I think it's best.

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
content/renderer/renderer_blink_platform_impl.cc:461: bool
RendererBlinkPlatformImpl::MimeRegistry::supportsEncryptedMediaMIMEType(
This function is currently used by unprefixed EME, but should not be:
https://code.google.com/p/chromium/issues/detail?id=385874#c14.

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
content/renderer/renderer_blink_platform_impl.cc:482: mime_type_ascii,
codec_vector, base::UTF16ToASCII(key_system), true);
That makes true incorrect.

[jrummell, 2015-02-03 00:40:49]

Updated to add/use PrefixedIsSupportedKeySystemWithMediaMimeType().

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
content/renderer/renderer_blink_platform_impl.cc:422: if
(!media::IsSupportedKeySystemWithMediaMimeType(
On 2015/01/27 00:51:51, ddorwin wrote:
> Instead of adding a bool, the purpose of which is not obvious at the call
site,
> change the function name to contain "Prefixed". You can hide the bool
internally
> if necessary.
> 
> (I'm not sure where to put "Prefixed". Prefixing the function name would be
the
> most obvious, but is probably not style compliant. Still, as far as
readability
> is concerned, I think it's best.

Done.

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
content/renderer/renderer_blink_platform_impl.cc:461: bool
RendererBlinkPlatformImpl::MimeRegistry::supportsEncryptedMediaMIMEType(
On 2015/01/27 00:51:51, ddorwin wrote:
> This function is currently used by unprefixed EME, but should not be:
> https://code.google.com/p/chromium/issues/detail?id=385874#c14.

Acknowledged.

https://codereview.chromium.org/875073004/diff/1/content/renderer/renderer_bl...
content/renderer/renderer_blink_platform_impl.cc:482: mime_type_ascii,
codec_vector, base::UTF16ToASCII(key_system), true);
On 2015/01/27 00:51:51, ddorwin wrote:
> That makes true incorrect.

Done.

[ddorwin, 2015-02-04 22:44:54]

lgtm

https://codereview.chromium.org/875073004/diff/20001/content/renderer/rendere...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/875073004/diff/20001/content/renderer/rendere...
content/renderer/renderer_blink_platform_impl.cc:461: bool
RendererBlinkPlatformImpl::MimeRegistry::supportsEncryptedMediaMIMEType(
We should probably add a note somewhere and a TODO that this is only used by
unprefixed but should be eliminated (385874).

[jrummell, 2015-02-05 00:44:10]

New patchsets have been uploaded after l-g-t-m from ddorwin@chromium.org

[jrummell, 2015-02-05 00:47:45]

jrummell@chromium.org changed reviewers:
+ davidben@chromium.org

[jrummell, 2015-02-05 00:47:46]

+davidben@ for OWNERS review of trivial change in
content/renderer/renderer_blink_platform_impl.cc

https://codereview.chromium.org/875073004/diff/20001/content/renderer/rendere...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/875073004/diff/20001/content/renderer/rendere...
content/renderer/renderer_blink_platform_impl.cc:461: bool
RendererBlinkPlatformImpl::MimeRegistry::supportsEncryptedMediaMIMEType(
On 2015/02/04 22:44:54, ddorwin wrote:
> We should probably add a note somewhere and a TODO that this is only used by
> unprefixed but should be eliminated (385874).

Done.

[ddorwin, 2015-02-05 00:51:24]

LGTM with minor comment.

https://codereview.chromium.org/875073004/diff/40001/content/renderer/rendere...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/875073004/diff/40001/content/renderer/rendere...
content/renderer/renderer_blink_platform_impl.cc:465: // TODO(jrummell): This
method is only used by unprefixed EME, and should not
This applies to the whole method (right?), so it should be above 461.

[davidben, 2015-02-05 00:59:37]

lgtm

[jrummell, 2015-02-05 01:03:40]

New patchsets have been uploaded after l-g-t-m from
ddorwin@chromium.org,davidben@chromium.org

[jrummell, 2015-02-05 01:04:20]

Thanks for the reviews.

https://codereview.chromium.org/875073004/diff/40001/content/renderer/rendere...
File content/renderer/renderer_blink_platform_impl.cc (right):

https://codereview.chromium.org/875073004/diff/40001/content/renderer/rendere...
content/renderer/renderer_blink_platform_impl.cc:465: // TODO(jrummell): This
method is only used by unprefixed EME, and should not
On 2015/02/05 00:51:23, ddorwin wrote:
> This applies to the whole method (right?), so it should be above 461.

Done.

[jrummell, 2015-02-05 01:04:24]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-02-05 01:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/875073004/60001

[commit-bot: I haz the power, 2015-02-05 02:49:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-05 02:50:38]

Patchset 4 (id:??) landed as
https://crrev.com/607b369291eb47c87582a0f9af2b5f0b4d031dfa
Cr-Commit-Position: refs/heads/master@{#314727}