Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 875053005: Revert of Fix --max_old_space_size=4096 integer overflow. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne, bnoordhuis
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Visibility:
Public.

Description

Revert of Fix --max_old_space_size=4096 integer overflow. (patchset #1 id:1 of https://codereview.chromium.org/890563003/) Reason for revert: Win64 compile failure. Original issue's description: > Fix --max_old_space_size=4096 integer overflow. > > R=yangguo@chromium.org > > Committed: https://crrev.com/6253aa8908c55535473ddbe1db8e5a6f5e559b73 > Cr-Commit-Position: refs/heads/master@{#26371} TBR=svenpanne@chromium.org,ben@strongloop.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b856e8785933a2a9cd884ab8966fee0e7098927e Cr-Commit-Position: refs/heads/master@{#26372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -41 lines) Patch
M src/flag-definitions.h View 3 chunks +13 lines, -15 lines 0 comments Download
M src/flags.cc View 8 chunks +2 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
Created Revert of Fix --max_old_space_size=4096 integer overflow.
5 years, 10 months ago (2015-01-31 21:44:56 UTC) #1
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 10 months ago (2015-01-31 21:48:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b856e8785933a2a9cd884ab8966fee0e7098927e Cr-Commit-Position: refs/heads/master@{#26372}
5 years, 10 months ago (2015-02-01 08:09:03 UTC) #4
Yang
5 years, 10 months ago (2015-02-01 08:09:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b856e8785933a2a9cd884ab8966fee0e7098927e (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698