Issue 875043004: win: Partial fixes for client_test after CrashReportDatabase added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 875043004: win: Partial fixes for client_test after CrashReportDatabase added (Closed)

Created:
5 years, 11 months ago by scottmg

Modified:
5 years, 11 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: Partial fixes for client_test after CrashReportDatabase added - Dependency on compat required for sys/types.h inclusion for ssize_t. - Test impl of stat to avoid #error - FileHandle isn't int on Windows. client_test no longer links though, as it's still lacking an implementation of CrashReportDatabase of course. R=rsesek@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7cd1639990084cae2b033cf4f8743168975011d1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	client/client.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	client/crash_report_database_test.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Robert Sesek

LGTM. Oops, I could have done the stat one for you.

5 years, 11 months ago (2015-01-26 21:52:21 UTC) #2

scottmg

On 2015/01/26 21:52:21, Robert Sesek wrote: > LGTM. Oops, I could have done the stat ...

5 years, 11 months ago (2015-01-26 21:56:13 UTC) #3

scottmg

5 years, 11 months ago (2015-01-26 21:56:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7cd1639990084cae2b033cf4f8743168975011d1 (presubmit successful).