Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
875043002:
Fix Chrome build (Closed)
|
Created:
5 years, 11 months ago by robertphillips Modified:
5 years, 11 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionFix Chrome build
Switch SkShader's toString method to not be pure virtual due to derived classes in Chromium
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Committed: https://skia.googlesource.com/skia/+/0a482f44141ee101bdd59b0a607c193c7c0446b7
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
robertphillips@google.com changed reviewers: + fmalita@chromium.org, fmalita@google.com
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 875043002-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
robertphillips@google.com changed reviewers: + bsalomon@google.com
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 875043002-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 875043002-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 875043002-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875043002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0a482f44141ee101bdd59b0a607c193c7c0446b7 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
