chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 87503004: Pass the Translate error type to the bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 87503004: Pass the Translate error type to the bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (rebasing) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 4ef89bfbe226dd4223c688b76152f17efa8affbc..197fe3a5d27971351d123631d2950c389b36a546 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -499,7 +499,9 @@ void BrowserWindowCocoa::ShowBookmarkBubble(const GURL& url,

void BrowserWindowCocoa::ShowTranslateBubble(

content::WebContents* contents,

- TranslateBubbleModel::ViewState view_state) {

+ TranslateBubbleModel::ViewState view_state,

+ TranslateErrors::Type error_type) {

+ NOTIMPLEMENTED();

}

#if defined(ENABLE_ONE_CLICK_SIGNIN)