Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: Source/core/rendering/svg/RenderSVGInlineText.cpp

Issue 87503003: Moving fontSelector from StyleResolver to StyleEngine. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reverted hasAnyFontFaceRule Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz> 2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
3 * Copyright (C) 2006 Apple Computer Inc. 3 * Copyright (C) 2006 Apple Computer Inc.
4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
5 * Copyright (C) 2008 Rob Buis <buis@kde.org> 5 * Copyright (C) 2008 Rob Buis <buis@kde.org>
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
11 * version 2 of the License, or (at your option) any later version. 11 * version 2 of the License, or (at your option) any later version.
12 * 12 *
13 * This library is distributed in the hope that it will be useful, 13 * This library is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 * Library General Public License for more details. 16 * Library General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU Library General Public License 18 * You should have received a copy of the GNU Library General Public License
19 * along with this library; see the file COPYING.LIB. If not, write to 19 * along with this library; see the file COPYING.LIB. If not, write to
20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
21 * Boston, MA 02110-1301, USA. 21 * Boston, MA 02110-1301, USA.
22 */ 22 */
23 23
24 #include "config.h" 24 #include "config.h"
25 25
26 #include "core/rendering/svg/RenderSVGInlineText.h" 26 #include "core/rendering/svg/RenderSVGInlineText.h"
27 27
28 #include "core/css/CSSFontSelector.h" 28 #include "core/css/CSSFontSelector.h"
29 #include "core/css/FontSize.h" 29 #include "core/css/FontSize.h"
30 #include "core/css/resolver/StyleResolver.h"
31 #include "core/editing/VisiblePosition.h" 30 #include "core/editing/VisiblePosition.h"
32 #include "core/rendering/svg/RenderSVGText.h" 31 #include "core/rendering/svg/RenderSVGText.h"
33 #include "core/rendering/svg/SVGInlineTextBox.h" 32 #include "core/rendering/svg/SVGInlineTextBox.h"
34 #include "core/rendering/svg/SVGRenderingContext.h" 33 #include "core/rendering/svg/SVGRenderingContext.h"
35 34
36 namespace WebCore { 35 namespace WebCore {
37 36
38 static PassRefPtr<StringImpl> applySVGWhitespaceRules(PassRefPtr<StringImpl> str ing, bool preserveWhiteSpace) 37 static PassRefPtr<StringImpl> applySVGWhitespaceRules(PassRefPtr<StringImpl> str ing, bool preserveWhiteSpace)
39 { 38 {
40 if (preserveWhiteSpace) { 39 if (preserveWhiteSpace) {
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 computeNewScaledFontForStyle(this, style(), m_scalingFactor, m_scaledFont); 213 computeNewScaledFontForStyle(this, style(), m_scalingFactor, m_scaledFont);
215 } 214 }
216 215
217 void RenderSVGInlineText::computeNewScaledFontForStyle(RenderObject* renderer, c onst RenderStyle* style, float& scalingFactor, Font& scaledFont) 216 void RenderSVGInlineText::computeNewScaledFontForStyle(RenderObject* renderer, c onst RenderStyle* style, float& scalingFactor, Font& scaledFont)
218 { 217 {
219 ASSERT(style); 218 ASSERT(style);
220 ASSERT(renderer); 219 ASSERT(renderer);
221 220
222 Document& document = renderer->document(); 221 Document& document = renderer->document();
223 222
224 StyleResolver* styleResolver = document.styleResolver();
225 ASSERT(styleResolver);
226
227 // Alter font-size to the right on-screen value to avoid scaling the glyphs themselves, except when GeometricPrecision is specified. 223 // Alter font-size to the right on-screen value to avoid scaling the glyphs themselves, except when GeometricPrecision is specified.
228 scalingFactor = SVGRenderingContext::calculateScreenFontSizeScalingFactor(re nderer); 224 scalingFactor = SVGRenderingContext::calculateScreenFontSizeScalingFactor(re nderer);
229 if (scalingFactor == 1 || !scalingFactor) { 225 if (scalingFactor == 1 || !scalingFactor) {
230 scalingFactor = 1; 226 scalingFactor = 1;
231 scaledFont = style->font(); 227 scaledFont = style->font();
232 return; 228 return;
233 } 229 }
234 230
235 if (style->fontDescription().textRenderingMode() == GeometricPrecision) 231 if (style->fontDescription().textRenderingMode() == GeometricPrecision)
236 scalingFactor = 1; 232 scalingFactor = 1;
237 233
238 FontDescription fontDescription(style->fontDescription()); 234 FontDescription fontDescription(style->fontDescription());
239 235
240 // FIXME: We need to better handle the case when we compute very small fonts below (below 1pt). 236 // FIXME: We need to better handle the case when we compute very small fonts below (below 1pt).
241 fontDescription.setComputedSize(FontSize::getComputedSizeFromSpecifiedSize(& document, scalingFactor, fontDescription.isAbsoluteSize(), fontDescription.speci fiedSize(), DoNotUseSmartMinimumForFontSize)); 237 fontDescription.setComputedSize(FontSize::getComputedSizeFromSpecifiedSize(& document, scalingFactor, fontDescription.isAbsoluteSize(), fontDescription.speci fiedSize(), DoNotUseSmartMinimumForFontSize));
242 238
243 scaledFont = Font(fontDescription, 0, 0); 239 scaledFont = Font(fontDescription, 0, 0);
244 scaledFont.update(styleResolver->fontSelector()); 240 scaledFont.update(document.fontSelector());
245 } 241 }
246 242
247 } 243 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698