Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 874993003: Perform full GC if incremental marking is completed or marking deque is empty. (Closed)

Created:
5 years, 10 months ago by Hannes Payer (out of office)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Perform full GC if incremental marking is completed or marking deque is empty. BUG= Committed: https://crrev.com/8e838f705c32c5a40e4618d47f8feaa4ca41757a Cr-Commit-Position: refs/heads/master@{#26272}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 10 months ago (2015-01-26 14:04:49 UTC) #2
jochen (gone - plz use gerrit)
lgtm with question answered https://codereview.chromium.org/874993003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/874993003/diff/1/src/heap/heap.cc#newcode831 src/heap/heap.cc:831: !mark_compact_collector_.marking_deque_.IsEmpty() && !FLAG_gc_global) { should ...
5 years, 10 months ago (2015-01-26 14:09:01 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/874993003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/874993003/diff/1/src/heap/heap.cc#newcode831 src/heap/heap.cc:831: !mark_compact_collector_.marking_deque_.IsEmpty() && !FLAG_gc_global) { On 2015/01/26 14:09:01, jochen (slow) ...
5 years, 10 months ago (2015-01-26 14:52:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874993003/1
5 years, 10 months ago (2015-01-26 14:53:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-26 14:55:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-26 14:55:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e838f705c32c5a40e4618d47f8feaa4ca41757a
Cr-Commit-Position: refs/heads/master@{#26272}

Powered by Google App Engine
This is Rietveld 408576698