Issue 874933003: Fix build with gcc after #313406

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 874933003: Fix build with gcc after #313406 (Closed)

Created:
5 years, 10 months ago by kbalazs

Modified:
5 years, 10 months ago

Reviewers:
nshaik, Nico

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix build with gcc after #313406 Multiple friend declaration is causing warning with gcc 4.8.2 (at least). Committed: https://crrev.com/3747c3ae2d547305ecaa41e86fb90d22e7ce75ca Cr-Commit-Position: refs/heads/master@{#313657}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chrome/browser/history/in_memory_history_backend.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 8 (2 generated)

kbalazs

The original change is https://codereview.chromium.org/773103004

5 years, 10 months ago (2015-01-29 01:05:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874933003/1

5 years, 10 months ago (2015-01-29 02:15:21 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 03:10:31 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3747c3ae2d547305ecaa41e86fb90d22e7ce75ca
Cr-Commit-Position: refs/heads/master@{#313657}