Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 874933002: Fixes and reenables SystemUse24HourClockPolicyTest (Closed)

Created:
5 years, 11 months ago by cschuet (SLOW)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes and reenables SystemUse24HourClockPolicyTest Adds code which attempts to exit by closing all browser instances and gracefully shuts down the test. BUG=450651 Committed: https://crrev.com/a55d03762d344abc6742c82aba04cd7b2c48224c Cr-Commit-Position: refs/heads/master@{#313056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc View 5 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cschuet (SLOW)
5 years, 11 months ago (2015-01-26 09:09:05 UTC) #2
Andrew T Wilson (Slow)
LGTM. Ideally we'd have some kind of LoginScreenBrowserTest base class that does this - if ...
5 years, 11 months ago (2015-01-26 09:19:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874933002/1
5 years, 11 months ago (2015-01-26 09:28:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 10:13:33 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 10:14:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a55d03762d344abc6742c82aba04cd7b2c48224c
Cr-Commit-Position: refs/heads/master@{#313056}

Powered by Google App Engine
This is Rietveld 408576698