Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 874893003: Handles aria-dropeffect after getting its value from blink. (Closed)

Created:
5 years, 11 months ago by je_julie(Not used)
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handles aria-dropeffect after getting its value from blink. This patch adds the conversion rule for aria-dropeffect at chromium, the aria-dropeffect test case and expected results. The related patch is http://crrev.com/863283005. BUG=98817 Committed: https://crrev.com/47c4a4dace3445744eb11529aa1c2e35e477a447 Cr-Commit-Position: refs/heads/master@{#315501}

Patch Set 1 #

Patch Set 2 : Update test results #

Total comments: 1

Patch Set 3 : Fix typo #

Messages

Total messages: 10 (4 generated)
je_julie(Not used)
Hi Dominic, This patch handles aria-dropeffect at chrome. PTAL.
5 years, 10 months ago (2015-02-09 13:26:07 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/874893003/diff/40001/content/test/data/accessibility/aria/aria-dropeffect.html File content/test/data/accessibility/aria/aria-dropeffect.html (right): https://codereview.chromium.org/874893003/diff/40001/content/test/data/accessibility/aria/aria-dropeffect.html#newcode11 content/test/data/accessibility/aria/aria-dropeffect.html:11: <li aria-dropeffect="none">none(defalut)</li> nit: defalut -> default
5 years, 10 months ago (2015-02-09 16:12:46 UTC) #4
je_julie(Not used)
On 2015/02/09 16:12:46, dmazzoni wrote: > lgtm > > https://codereview.chromium.org/874893003/diff/40001/content/test/data/accessibility/aria/aria-dropeffect.html > File content/test/data/accessibility/aria/aria-dropeffect.html (right): > ...
5 years, 10 months ago (2015-02-10 04:01:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874893003/60001
5 years, 10 months ago (2015-02-10 04:31:34 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-10 05:28:28 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 05:29:01 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47c4a4dace3445744eb11529aa1c2e35e477a447
Cr-Commit-Position: refs/heads/master@{#315501}

Powered by Google App Engine
This is Rietveld 408576698