[ServiceWorker] Block all mixed-content requests from a ServiceWorker.

[ServiceWorker] Block all mixed-content requests from a ServiceWorker.

While we don't support FetchEvent.default() yet, all mixed-content requests from a ServiceWorker must be blocked.

BUG=448672, 392409
TEST=http/tests/serviceworker/ http/tests/fetch/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188951

[horo, 2015-01-26 02:13:03]

horo@chromium.org changed reviewers:
+ kinuko@chromium.org

[horo, 2015-01-26 02:13:03]

kinuko@
Could you please review this?

[kinuko, 2015-01-26 04:51:45]

lgtm

(Would be nice to have TEST= field so that it's clear that it's still tested by
the test)

[horo, 2015-01-26 04:55:38]

horo@chromium.org changed reviewers:
+ mkwst@chromium.org

[horo, 2015-01-26 04:55:39]

mkwst@
Could you please review this?

[Mike West, 2015-01-26 10:04:53]

LGTM % comments.

https://codereview.chromium.org/874833003/diff/1/Source/web/WebEmbeddedWorker...
File Source/web/WebEmbeddedWorkerImpl.cpp (right):

https://codereview.chromium.org/874833003/diff/1/Source/web/WebEmbeddedWorker...
Source/web/WebEmbeddedWorkerImpl.cpp:314:
settings->setStrictMixedContentChecking(true);
This settings object only takes effect for this worker, right? I assume we throw
the webview away after the worker is destructed, and don't use it for any
page-level security checks?

https://codereview.chromium.org/874833003/diff/1/Source/web/WebEmbeddedWorker...
Source/web/WebEmbeddedWorkerImpl.cpp:316:
settings->setAllowRunningOfInsecureContent(false);
Setting strict mode will stop notifications up to the frame client; that might
or might not be what you want. It will prevent UI degradation, but it will also
prevent the mixed content shield icon from showing up for user override, and
will stop any browser-side UMA measurement.

As long as everything mixed-content-related that you want to measure happens on
the blink side, that's fine, but it's something to consider.

[horo, 2015-01-26 11:17:15]

Thank you!

https://codereview.chromium.org/874833003/diff/1/Source/web/WebEmbeddedWorker...
File Source/web/WebEmbeddedWorkerImpl.cpp (right):

https://codereview.chromium.org/874833003/diff/1/Source/web/WebEmbeddedWorker...
Source/web/WebEmbeddedWorkerImpl.cpp:314:
settings->setStrictMixedContentChecking(true);
On 2015/01/26 10:04:53, Mike West wrote:
> This settings object only takes effect for this worker, right? I assume we
throw
> the webview away after the worker is destructed, and don't use it for any
> page-level security checks?

Yes. This WebView is only used for the resource loading requests from the
ServiceWorker.

https://codereview.chromium.org/874833003/diff/1/Source/web/WebEmbeddedWorker...
Source/web/WebEmbeddedWorkerImpl.cpp:316:
settings->setAllowRunningOfInsecureContent(false);
On 2015/01/26 10:04:53, Mike West wrote:
> Setting strict mode will stop notifications up to the frame client; that might
> or might not be what you want. It will prevent UI degradation, but it will
also
> prevent the mixed content shield icon from showing up for user override, and
> will stop any browser-side UMA measurement.
> 
> As long as everything mixed-content-related that you want to measure happens
on
> the blink side, that's fine, but it's something to consider.

We discussed with rsleevi@ and decided to block all mixed-content requests from
ServiceWorkers for M42.
This ensures that the ServiceWorker will not touch any HTTP responses.

And for M43, we will implement the browser side buffering for No-CORS
mixed-content requests.
https://docs.google.com/document/d/1y6X8rVhkP_fQeC2awsG8mSCVTorw9FLniOncVLtT1...

[horo, 2015-01-26 11:17:38]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2015-01-26 11:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874833003/1

[horo, 2015-01-26 11:53:21]

The CQ bit was unchecked by horo@chromium.org

[horo, 2015-01-26 12:30:57]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2015-01-26 12:31:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874833003/1

[commit-bot: I haz the power, 2015-01-26 12:34:10]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188951