Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874823002: Move GestureEvent to NewEventDispatcher (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel1, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move GestureEvent to NewEventDispatcher The Sky engine doesn't respond to gesture events itself. Instead, the framework will listen for gestures and respond to them. That means moving GestureEvents over to the NewEventDispatcher is relatively straightforward. R=eseidel@google.com, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ccc8f78320433bbd73e62b8b51a9459756e7354c

Patch Set 1 #

Patch Set 2 : Build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -1124 lines) Patch
M sky/engine/core/dom/Node.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/events/Event.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/Event.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/events/EventTypeNames.in View 1 chunk +10 lines, -0 lines 0 comments Download
M sky/engine/core/events/GestureEvent.h View 1 chunk +33 lines, -70 lines 0 comments Download
M sky/engine/core/events/GestureEvent.cpp View 3 chunks +66 lines, -108 lines 0 comments Download
M sky/engine/core/events/GestureEvent.idl View 1 chunk +5 lines, -12 lines 0 comments Download
M sky/engine/core/events/PointerEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/events/PointerEvent.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M sky/engine/core/frame/NewEventHandler.h View 3 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/frame/NewEventHandler.cpp View 4 chunks +16 lines, -1 line 0 comments Download
M sky/engine/core/page/EventHandler.h View 6 chunks +0 lines, -40 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 5 chunks +0 lines, -364 lines 0 comments Download
M sky/engine/core/page/EventWithHitTestResults.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/PlatformEvent.h View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/engine/platform/PlatformGestureEvent.h View 1 chunk +0 lines, -161 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 2 chunks +0 lines, -45 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/public/web/WebWidgetClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.h View 2 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 1 4 chunks +0 lines, -163 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 4 chunks +5 lines, -84 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-24 08:21:31 UTC) #1
eseidel1
ok. rs-lgtm
5 years, 11 months ago (2015-01-24 18:50:40 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-24 19:18:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ccc8f78320433bbd73e62b8b51a9459756e7354c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698