Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 8748019: Make sure the document's scroll position is always up-to-date before... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by dmazzoni
Modified:
3 years, 3 months ago
Reviewers:
jam, David Tseng
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Make sure the document's scroll position is always up-to-date before sending an accessibility notification. This can be removed once https://bugs.webkit.org/show_bug.cgi?id=73460 is fixed, but it's useful to have this change in the meantime because it enables progress on other bugs to proceed in the meantime. BUG=72318, 104468 TEST=Compare the rects of web objects using accessibility inspectors before and after scrolling. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112423

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M content/renderer/renderer_accessibility.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/renderer_accessibility.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
Trybot results:
Commit:

Messages

Total messages: 5 (0 generated)
dmazzoni
dtseng: review jam: approval for content/renderer
3 years, 3 months ago (2011-11-30 19:42:01 UTC) #1
David Tseng
lgtm
3 years, 3 months ago (2011-12-01 01:11:01 UTC) #2
jam
lgtm
3 years, 3 months ago (2011-12-01 03:57:20 UTC) #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8748019/1003
3 years, 3 months ago (2011-12-01 06:34:39 UTC) #4
I haz the power (commit-bot)
3 years, 3 months ago (2011-12-01 07:44:22 UTC) #5
Change committed as 112423
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87e6a26