Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Unified Diff: base/process/kill_win.cc

Issue 874773002: Remove CloseProcessHandle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/process/process_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/kill_win.cc
diff --git a/base/process/kill_win.cc b/base/process/kill_win.cc
index 4d7225f46c1985a15ecf0f73808ba8f1fd189f4b..f280c6fa1d8e05351f0d988e990055390a203f29 100644
--- a/base/process/kill_win.cc
+++ b/base/process/kill_win.cc
@@ -182,10 +182,9 @@ TerminationStatus GetTerminationStatus(ProcessHandle handle, int* exit_code) {
}
bool WaitForExitCode(ProcessHandle handle, int* exit_code) {
- bool success = WaitForExitCodeWithTimeout(
- handle, exit_code, base::TimeDelta::FromMilliseconds(INFINITE));
- CloseProcessHandle(handle);
- return success;
+ // TODO(rvargas) crbug.com/417532: Remove this function.
+ Process process(handle);
+ return process.WaitForExit(exit_code);
}
bool WaitForExitCodeWithTimeout(ProcessHandle handle,
« no previous file with comments | « no previous file | base/process/process_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698