Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2501)

Unified Diff: build/config/compiler/BUILD.gn

Issue 874743007: Revert of Linux: Enable ODR violation detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/libphonenumber/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 48950664f6b98d7494d81fe82651786850e592a0..164b97d26260f3e238834c36ffad1e9e53037f5c 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -71,7 +71,7 @@
#
# Base compiler configuration.
#
-# See also "runtime_library" below for related stuff and a discussion about
+# See also "runtime_library" below for related stuff and a discusison about
# where stuff should go. Put warning related stuff in the "warnings" config.
config("compiler") {
@@ -385,13 +385,6 @@
#"-Wl,--threads",
#"-Wl,--thread-count=4",
]
-
- # TODO(thestig): Make this flag work with GN.
- #if (!is_chromeos && !(is_asan || is_lsan || is_tsan || is_msan)) {
- # ldflags += [
- # "-Wl,--detect-odr-violations",
- # ]
- #}
}
if (linux_use_bundled_binutils) {
« no previous file with comments | « build/common.gypi ('k') | third_party/libphonenumber/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698