Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 874743003: Revert of Remove the use of page id from building the commit params. (Closed)

Created:
5 years, 10 months ago by Avi (use Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the use of page id from building the commit params. (patchset #4 id:60001 of https://codereview.chromium.org/839413004/) Reason for revert: NavigationControllerBrowserTest.ManualAndAutoSubframeNavigationTransitions fails on the --site-per-process FYI bot Original issue's description: > Remove the use of page id from building the commit params. > > BUG=369661 > TEST=tests stay green > > Committed: https://crrev.com/66f3ec8e5ee6c3b528b5a6054cdca85ac0b29699 > Reverted: https://crrev.com/96545af0f94ec1ac19a57c86806c95834de5d33c > > Committed: https://crrev.com/5fe8124cafd9ea996b99cfc88366315aad0c63b2 > Cr-Commit-Position: refs/heads/master@{#313589} TBR=creis@chromium.org,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/b05344954395b9cbb021057269875d931268dfd0 Cr-Commit-Position: refs/heads/master@{#313765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -118 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 2 chunks +1 line, -106 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Remove the use of page id from building the commit params.
5 years, 10 months ago (2015-01-29 19:53:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874743003/1
5 years, 10 months ago (2015-01-29 19:53:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 19:55:30 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 19:57:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b05344954395b9cbb021057269875d931268dfd0
Cr-Commit-Position: refs/heads/master@{#313765}

Powered by Google App Engine
This is Rietveld 408576698