Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 874723002: [PATCH 9/11] ozone: evdev: Add a device event dispatcher that forwards to UI thread (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Add a device event dispatcher that forwards to UI thread This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. Make a new class ForwardingDeviceEventDispatcher that wraps EventFactoryOzone and can be safely passed to another thread. When the other thread dispatches, we'll post to EventFactoryOzone on the UI thread with the event. BUG=449710 TEST=boot link_freon & move mouse Committed: https://crrev.com/673df3d93162edb9ad89544a1979d58a15b35cc5 Cr-Commit-Position: refs/heads/master@{#313875}

Patch Set 1 #

Patch Set 2 : updates for events_unittests #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -101 lines) Patch
M ui/events/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 2 4 chunks +10 lines, -34 lines 0 comments Download
A ui/events/ozone/evdev/event_converter_test_util.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/event_converter_test_util.cc View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 2 chunks +15 lines, -17 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 3 2 chunks +90 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.h View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 1 2 4 chunks +8 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
spang
5 years, 11 months ago (2015-01-23 22:01:40 UTC) #2
spang
5 years, 11 months ago (2015-01-27 19:34:41 UTC) #3
alexst (slow to review)
lgtm https://codereview.chromium.org/874723002/diff/20001/ui/events/ozone/evdev/event_factory_evdev.cc File ui/events/ozone/evdev/event_factory_evdev.cc (right): https://codereview.chromium.org/874723002/diff/20001/ui/events/ozone/evdev/event_factory_evdev.cc#newcode25 ui/events/ozone/evdev/event_factory_evdev.cc:25: class ForwardingDeviceEventDispatcher : public DeviceEventDispatcherEvdev { DeviceEventDispatcherProxy?
5 years, 10 months ago (2015-01-28 18:35:30 UTC) #4
spang
On 2015/01/28 18:35:30, alexst wrote: > lgtm > > https://codereview.chromium.org/874723002/diff/20001/ui/events/ozone/evdev/event_factory_evdev.cc > File ui/events/ozone/evdev/event_factory_evdev.cc (right): > ...
5 years, 10 months ago (2015-01-28 21:05:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874723002/60001
5 years, 10 months ago (2015-01-30 04:35:28 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-30 06:22:54 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 06:24:00 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/673df3d93162edb9ad89544a1979d58a15b35cc5
Cr-Commit-Position: refs/heads/master@{#313875}

Powered by Google App Engine
This is Rietveld 408576698