[Android L] Add (dis)chargingTime support for the Battery Status API.

[Android L] Add (dis)chargingTime support for the Battery Status API.

This patch implements the estimation of (dis)chargingTime on devices
running Android L (and above). Android L supports new properties in
BatteryManager which can be used to provide such estimates.

BUG=401553
TEST=http://jsbin.com/battery-status-test

Committed: https://crrev.com/13e397e55501bee3903bfe46edfd56f2442c1f11
Cr-Commit-Position: refs/heads/master@{#317372}

[timvolodine, 2015-02-03 15:17:43]

timvolodine@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2015-02-03 15:37:44]

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
File
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
(right):

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:45:
// Only used in L (API level 21 and higher) in production or for testing.
Is the section "in production or for testing" a meaningful addition? Isn't that
100% of the cases? Ah it's always in tests, but in production only for these
versions? Maybe you can rephrase this to be less ambiguous.

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:52:
BatteryManager batteryManager) {
@Nullable

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:62:
this(context, callback, Build.MODEL.equals("Galaxy Nexus"),
This call is hard to read. Could you extract the ignoreBatteryPresentState and
batteryManager arguments into local variables before calling this?

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:72:
Context context, BatteryStatusCallback callback, BatteryManager batteryManager)
{
@Nullable

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:131:
double chargingTime = (charging && batteryFull) ? 0 : Double.POSITIVE_INFINITY;
What are the units of time here? Could you rename these variables to include the
unit? E.g. if it's milliseconds use chargingTimeMs or if it's seconds use
chargingTimeSeconds.

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
File
device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java
(right):

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java:50:
private int mAverage;
mCurrentAverage

[timvolodine, 2015-02-04 17:36:06]

thanks for the comments Michael!

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
File
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
(right):

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:45:
// Only used in L (API level 21 and higher) in production or for testing.
On 2015/02/03 15:37:44, Michael van Ouwerkerk wrote:
> Is the section "in production or for testing" a meaningful addition? Isn't
that
> 100% of the cases? Ah it's always in tests, but in production only for these
> versions? Maybe you can rephrase this to be less ambiguous.

yeah right, it's actually always L and above now. Done.

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:52:
BatteryManager batteryManager) {
On 2015/02/03 15:37:44, Michael van Ouwerkerk wrote:
> @Nullable

Done.

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:62:
this(context, callback, Build.MODEL.equals("Galaxy Nexus"),
On 2015/02/03 15:37:44, Michael van Ouwerkerk wrote:
> This call is hard to read. Could you extract the ignoreBatteryPresentState and
> batteryManager arguments into local variables before calling this?

call to "this" must be the first statement in a constructor :(.

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:72:
Context context, BatteryStatusCallback callback, BatteryManager batteryManager)
{
On 2015/02/03 15:37:44, Michael van Ouwerkerk wrote:
> @Nullable

Done.

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:131:
double chargingTime = (charging && batteryFull) ? 0 : Double.POSITIVE_INFINITY;
On 2015/02/03 15:37:44, Michael van Ouwerkerk wrote:
> What are the units of time here? Could you rename these variables to include
the
> unit? E.g. if it's milliseconds use chargingTimeMs or if it's seconds use
> chargingTimeSeconds.

Done.

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
File
device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java
(right):

https://codereview.chromium.org/874713003/diff/60001/device/battery/android/j...
device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java:50:
private int mAverage;
On 2015/02/03 15:37:44, Michael van Ouwerkerk wrote:
> mCurrentAverage

made it mAverageCurrent. done.

[Michael van Ouwerkerk, 2015-02-04 17:45:48]

lgtm

[Michael van Ouwerkerk, 2015-02-13 11:18:50]

Tim, is this ready to land then?

[timvolodine, 2015-02-13 12:03:04]

On 2015/02/13 11:18:50, Michael van Ouwerkerk wrote:
> Tim, is this ready to land then?

I'll be landing this soon, just wanted to test on one more device..

[timvolodine, 2015-02-20 14:08:59]

New patchsets have been uploaded after l-g-t-m from mvanouwerkerk@chromium.org

[timvolodine, 2015-02-20 15:14:17]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2015-02-20 15:14:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874713003/100001

[commit-bot: I haz the power, 2015-02-20 15:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 15:41:01]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[timvolodine, 2015-02-20 15:47:26]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2015-02-20 15:48:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874713003/100001

[commit-bot: I haz the power, 2015-02-20 16:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 16:15:33]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[timvolodine, 2015-02-20 17:25:52]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2015-02-20 17:26:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874713003/120001

[commit-bot: I haz the power, 2015-02-20 18:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 18:58:17]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[timvolodine, 2015-02-20 19:01:30]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2015-02-20 19:02:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874713003/140001

[commit-bot: I haz the power, 2015-02-20 19:31:10]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-02-20 19:32:20]

Patchset 8 (id:??) landed as
https://crrev.com/13e397e55501bee3903bfe46edfd56f2442c1f11
Cr-Commit-Position: refs/heads/master@{#317372}