Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 874713002: [PATCH 1/11] ozone: evdev: Move touch ui::Event transformation to EventFactoryEvdev (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Move touch ui::Event transformation to EventFactoryEvdev This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. DeviceDataManager is a UI thread object, so move final transformation of touches into EventFactoryEvdev prior to dispatch into UI. This will avoid sharing state across threads. BUG=449710 TEST=boot link_freon & move cursor Committed: https://crrev.com/40ee4d543a2f09bf72e19f5db26e2f20d52e344c Cr-Commit-Position: refs/heads/master@{#313204}

Patch Set 1 #

Patch Set 2 : update touch_event_converter_evdev_unittest.cc #

Patch Set 3 : updates for events_unittests #

Total comments: 4

Patch Set 4 : update comment & add missing export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -147 lines) Patch
M ui/events/ozone/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_dispatch_callback.h View 1 2 3 2 chunks +37 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/event_dispatch_callback.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 3 5 chunks +30 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 2 chunks +8 lines, -31 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 13 chunks +91 lines, -113 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
spang
5 years, 11 months ago (2015-01-23 21:56:19 UTC) #2
alexst (slow to review)
https://codereview.chromium.org/874713002/diff/40001/ui/events/ozone/evdev/event_factory_evdev.cc File ui/events/ozone/evdev/event_factory_evdev.cc (right): https://codereview.chromium.org/874713002/diff/40001/ui/events/ozone/evdev/event_factory_evdev.cc#newcode209 ui/events/ozone/evdev/event_factory_evdev.cc:209: // Transform the event according (this is used to ...
5 years, 10 months ago (2015-01-26 18:20:13 UTC) #3
alexst (slow to review)
lgtm
5 years, 10 months ago (2015-01-26 22:08:16 UTC) #4
spang
https://codereview.chromium.org/874713002/diff/40001/ui/events/ozone/evdev/event_factory_evdev.cc File ui/events/ozone/evdev/event_factory_evdev.cc (right): https://codereview.chromium.org/874713002/diff/40001/ui/events/ozone/evdev/event_factory_evdev.cc#newcode209 ui/events/ozone/evdev/event_factory_evdev.cc:209: // Transform the event according (this is used to ...
5 years, 10 months ago (2015-01-26 23:43:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874713002/60001
5 years, 10 months ago (2015-01-27 01:09:01 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-27 01:57:53 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/40ee4d543a2f09bf72e19f5db26e2f20d52e344c Cr-Commit-Position: refs/heads/master@{#313204}
5 years, 10 months ago (2015-01-27 02:06:26 UTC) #9
spang
5 years, 10 months ago (2015-01-27 19:33:02 UTC) #10
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698