Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 874703003: PPAPI: Release renderer Var refcount when returning to plugin (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Release renderer Var refcount when returning to plugin BUG=451624 R=raymes@chromium.org Committed: https://crrev.com/64d576c36c2cf39d3ca14dba6bccfdf76291439e Cr-Commit-Position: refs/heads/master@{#313355}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M ppapi/proxy/host_var_serialization_rules.cc View 1 1 chunk +12 lines, -3 lines 0 comments Download
M ppapi/proxy/serialized_var_unittest.cc View 1 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dmichael (off chromium)
5 years, 11 months ago (2015-01-23 23:45:52 UTC) #1
raymes
lgtm! Thanks for doing this! https://codereview.chromium.org/874703003/diff/1/ppapi/proxy/host_var_serialization_rules.cc File ppapi/proxy/host_var_serialization_rules.cc (right): https://codereview.chromium.org/874703003/diff/1/ppapi/proxy/host_var_serialization_rules.cc#newcode49 ppapi/proxy/host_var_serialization_rules.cc:49: // See PluginVarSerialization::ReceivePassRef for ...
5 years, 11 months ago (2015-01-27 00:12:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874703003/20001
5 years, 11 months ago (2015-01-27 19:33:41 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 21:00:44 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 21:02:19 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64d576c36c2cf39d3ca14dba6bccfdf76291439e
Cr-Commit-Position: refs/heads/master@{#313355}

Powered by Google App Engine
This is Rietveld 408576698