Changes in chrome installer util target for Windows GN build.

Changes in chrome installer util target for Windows GN build.

Committed: https://crrev.com/53f5ed7f5423907ef1be51c8c783af1324259ee0
Cr-Commit-Position: refs/heads/master@{#313026}

[Slava Chigrin, 2015-01-23 20:53:02]

Patchset #1 (id:1) has been deleted

[Slava Chigrin, 2015-01-23 20:57:24]

vchigrin@yandex-team.ru changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[Slava Chigrin, 2015-01-23 20:58:11]

https://codereview.chromium.org/874703002/diff/20001/chrome/installer/util/BU...
File chrome/installer/util/BUILD.gn (right):

https://codereview.chromium.org/874703002/diff/20001/chrome/installer/util/BU...
chrome/installer/util/BUILD.gn:104: # TODO(GYP) installer_util on Windows.
Sorry, I am not familiar enough with GN to fix properly this TODO. So I've added
just list of common files (installer_util_common_sources). These changes at
least add neccessary files to allow "chrome" target be build in 32-bit mode on
Windows. If anybody could advise better approach, I will be glad to fix this.

https://codereview.chromium.org/874703002/diff/20001/chrome/installer/util/BU...
chrome/installer/util/BUILD.gn:157: "//third_party/bspatch",
GN files for this added in https://codereview.chromium.org/868193002/ , but not
committed yet, so I'll land this patch only after former patch will be
committed. Hope, this is acceptable.

[Dirk Pranke, 2015-01-23 21:00:20]

This basically looks okay to me, but I defer this to Brett since hopefully he's
the one who wrote the comments :).

[brettw, 2015-01-23 21:06:35]

https://codereview.chromium.org/874703002/diff/20001/chrome/installer/util/BU...
File chrome/installer/util/BUILD.gn (right):

https://codereview.chromium.org/874703002/diff/20001/chrome/installer/util/BU...
chrome/installer/util/BUILD.gn:165: sources += installer_util_common_sources
Can you just list the sources here rather than doing the variable? Then add a
TODO about hooking up the corresponding version of installer_util_nacl_win64 in
GN. The way this will work is that there wouldn't be a separate target for this
(unlike GYP) but rather this target would be referred to in the 64-bit
toolchain. 64/32 cross-compilation already works, but the specific toolchain for
"64-bit helpers for the 32-bit build" (as different from the "64 bit version of
this target") isn't hooked up yet.

[Slava Chigrin, 2015-01-23 21:29:15]

Uploaded new version, many thanks for so quick review!

https://codereview.chromium.org/874703002/diff/40001/chrome/installer/util/BU...
File chrome/installer/util/BUILD.gn (right):

https://codereview.chromium.org/874703002/diff/40001/chrome/installer/util/BU...
chrome/installer/util/BUILD.gn:76: sources += [
Two blocks of "sources" modifications (first on line 18) looks a bit strange,
but I assumed you mean to do it in this way, rather then merging lists, to ease
fix 64-bit issue in future (First list of sources should not be linked to 64-bit
version, according to GYP).

I can merge lists if I misunderstood you.

[brettw, 2015-01-23 21:52:27]

lgtm

https://codereview.chromium.org/874703002/diff/40001/chrome/installer/util/BU...
File chrome/installer/util/BUILD.gn (right):

https://codereview.chromium.org/874703002/diff/40001/chrome/installer/util/BU...
chrome/installer/util/BUILD.gn:76: sources += [
Right, I was thinking separating these to make the future changes easier.

[Slava Chigrin, 2015-01-24 17:18:13]

The CQ bit was checked by vchigrin@yandex-team.ru

[commit-bot: I haz the power, 2015-01-24 17:19:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874703002/40001

[commit-bot: I haz the power, 2015-01-24 19:33:40]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-01-24 19:34:47]

Patchset 2 (id:??) landed as
https://crrev.com/53f5ed7f5423907ef1be51c8c783af1324259ee0
Cr-Commit-Position: refs/heads/master@{#313026}