chrome/browser/resources/extensions/extension_list.js - Issue 874683005: [Extensions] Enable the scripts-require-action feature based on all-urls pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 874683005: [Extensions] Enable the scripts-require-action feature based on all-urls pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated metrics Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/permissions_updater_unittest.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index b8ab0d4a66a37583a7a6017dad241355cc6a3d44..0dc61fa43ece0d26ce4d0b2817b9255683316a09 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -51,6 +51,7 @@

* prettifiedPath: (string|undefined),

* recommendedInstall: boolean,

* runtimeErrors: (Array.<RuntimeError>|undefined),

+ * showAllUrls: boolean,

* suspiciousInstall: boolean,

* terminated: boolean,

* updateRequiredByPolicy: boolean,

@@ -58,7 +59,6 @@

* views: Array.<{renderViewId: number, renderProcessId: number,

* path: string, incognito: boolean,

* generatedBackgroundPage: boolean}>,

- * wantsAllUrls: boolean,

* wantsErrorCollection: boolean,

* wantsFileAccess: boolean,

* warnings: (Array|undefined)}}

@@ -260,7 +260,7 @@ cr.define('options', function() {

// The 'allow on all urls' checkbox. This should only be visible if

// active script restrictions are enabled. If they are not enabled, no

// extensions should want all urls.

- if (extension.wantsAllUrls) {

+ if (extension.showAllUrls) {

var allUrls = node.querySelector('.all-urls-control');

allUrls.addEventListener('click', function(e) {

chrome.send('extensionSettingsAllowOnAllUrls',