[Extensions] Enable the scripts-require-action feature based on all-urls pref

chrome/browser/extensions/extension_util.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_UTIL_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_UTIL_H_
 
 #include <string>
 
+#include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "url/gurl.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace content {
 class BrowserContext;
 }
 
 namespace gfx {
 class ImageSkia;
 }
 
 namespace extensions {
 
 class Extension;
 struct ExtensionInfo;
+class PermissionSet;
 
 namespace util {
 
 // Returns true if |extension_id| can run in an incognito window.
 bool IsIncognitoEnabled(const std::string& extension_id,
                         content::BrowserContext* context);
 
 // Sets whether |extension_id| can run in an incognito window. Reloads the
 // extension if it's enabled since this permission is applied at loading time
 // only. Note that an ExtensionService must exist.
@@ skipping 22 matching lines @@
                         bool allow);
 
 // Returns true if the extension with |extension_id| is allowed to execute
 // scripts on all urls (exempting chrome:// urls, etc) without explicit
 // user consent.
 // This should only be used with FeatureSwitch::scripts_require_action()
 // enabled.
 bool AllowedScriptingOnAllUrls(const std::string& extension_id,
                                content::BrowserContext* context);
 
+// Returns the default value for being allowed to script on all urls.
+bool DefaultAllowedScriptingOnAllUrls();
+
 // Sets whether the extension with |extension_id| is allowed to execute scripts
 // on all urls (exempting chrome:// urls, etc) without explicit user consent.
 // This should only be used with FeatureSwitch::scripts_require_action()
 // enabled.
 void SetAllowedScriptingOnAllUrls(const std::string& extension_id,
                                   content::BrowserContext* context,
                                   bool allowed);
 
 // Returns true if the --scripts-require-action flag would possibly affect
-// the given |extension|.
-bool ScriptsMayRequireActionForExtension(const Extension* extension);
+// the given |extension| and |permissions|. We pass in the |permissions|
+// explicitly, as we may need to check with permissions other than the ones
+// that are currently on the extension's PermissionsData.
+bool ScriptsMayRequireActionForExtension(
+    const Extension* extension,
+    const scoped_refptr<const PermissionSet>& permissions);

[not at google - send to devlin, 2015/02/06 00:26:56]

A little odd to be passing refcounted |extension| as a raw pointer but
|permissions| as a scoped_refptr. I'd just pass them both as a raw pointer.

[Devlin, 2015/02/06 18:58:43]

Done.

 
 // Returns true if |extension_id| can be launched (possibly only after being
 // enabled).
 bool IsAppLaunchable(const std::string& extension_id,
                      content::BrowserContext* context);
 
 // Returns true if |extension_id| can be launched without being enabled first.
 bool IsAppLaunchableWithoutEnabling(const std::string& extension_id,
                                     content::BrowserContext* context);
 
@@ skipping 34 matching lines @@
 // Returns true if the bookmark apps feature is enabled.
 //
 // TODO(benwells): http://crbug.com/441128: Remove this entirely once the
 // feature is stable.
 bool IsNewBookmarkAppsEnabled();
 
 }  // namespace util
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_UTIL_H_