Fix host installation on i686 Linux.

remoting/webapp/crd/js/host_installer.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  *
  * HostInstaller allows the caller to download the host binary and monitor the
  * install progress of the host by pinging the host periodically via native
  * messaging.
@@ skipping 60 matching lines @@
       port.onMessage.removeListener(onMessage);
       resolve(false);
     }
 
     port.onDisconnect.addListener(onDisconnected);
     port.onMessage.addListener(onMessage);
     port.postMessage({type: 'hello'});
   });
 };
 
+/** @type {Object.<string,string>} */
+remoting.HostInstaller.HOST_DOWNLOAD_URLS = {

[kelvinp, 2015/01/23 21:15:33]

With the new JS Compiler, you can make this truly private by:

Add the line below on line 28, before the constructor.

(function() {

Add the line below and the end of the file

})();

This wraps the class definition under the scope of an anonymous function so all
vars are truly private, as opposed to being part of the window namespace.  See
apps_v2_migration.js for an example.

then you can do

var HOST_DOWNLOAD_URLS_ = {
 ...
}

[Sergey Ulanov, 2015/01/23 21:26:19]

Done.

+  'Win32': 'http://dl.google.com/dl/edgedl/chrome-remote-desktop/' +
+               'chromeremotedesktophost.msi',
+  'Win64': 'http://dl.google.com/dl/edgedl/chrome-remote-desktop/' +
+               'chromeremotedesktophost.msi',
+  'MacIntel': 'https://dl.google.com/chrome-remote-desktop/' +
+                  'chromeremotedesktop.dmg',
+  'Linux x86_64': 'https://dl.google.com/linux/direct/' +
+                      'chrome-remote-desktop_current_amd64.deb',
+  'Linux i386': 'https://dl.google.com/linux/direct/' +
+                    'chrome-remote-desktop_current_i386.deb',
+  'Linux i686': 'https://dl.google.com/linux/direct/' +
+                    'chrome-remote-desktop_current_i386.deb'
+};
+
+/**
+ * Returns true if the host is installable on the current platform.
+ * @returns {boolean}
+ */
+remoting.HostInstaller.canInstall = function() {
+  return !!remoting.HostInstaller.HOST_DOWNLOAD_URLS[navigator.platform];
+};
+
 /**
  * @throws {Error}  Throws if there is no matching host binary for the current
  *     platform.
  */
 remoting.HostInstaller.prototype.download = function() {
-  /** @type {Object.<string,string>} */
-  var hostDownloadUrls = {
-    'Win32' : 'http://dl.google.com/dl/edgedl/chrome-remote-desktop/' +
-        'chromeremotedesktophost.msi',
-    'Win64' : 'http://dl.google.com/dl/edgedl/chrome-remote-desktop/' +
-        'chromeremotedesktophost.msi',
-    'MacIntel' : 'https://dl.google.com/chrome-remote-desktop/' +
-        'chromeremotedesktop.dmg',
-    'Linux x86_64' : 'https://dl.google.com/linux/direct/' +
-        'chrome-remote-desktop_current_amd64.deb',
-    'Linux i386' : 'https://dl.google.com/linux/direct/' +
-        'chrome-remote-desktop_current_i386.deb'
-  };
-
-  var hostPackageUrl = hostDownloadUrls[navigator.platform];
+  var hostPackageUrl =
+      remoting.HostInstaller.HOST_DOWNLOAD_URLS[navigator.platform];
   if (hostPackageUrl === undefined) {
-    throw new Error(remoting.Error.CANCELLED);
+    console.error("Tried to install host on " + navigator.platform);
+    throw new Error(remoting.Error.UNEXPECTED);
   }
 
   // Start downloading the package.
   if (base.isAppsV2()) {
     // TODO(jamiewalch): Use chrome.downloads when it is available to
     // apps v2 (http://crbug.com/174046)
     window.open(hostPackageUrl);
   } else {
     window.location = hostPackageUrl;
   }
@@ skipping 43 matching lines @@
  *   var promise = hostInstaller.downloadAndWaitForInstall();
  *   hostInstaller.cancel(); // This will prevent |promise| from fulfilling.
  */
 remoting.HostInstaller.prototype.cancel = function() {
   if (this.checkInstallIntervalId_ !== null) {
     window.clearInterval(this.checkInstallIntervalId_);
     this.checkInstallIntervalId_ = null;
   }
   this.downloadAndWaitForInstallPromise_ = null;
 };